redis-ratelimit icon indicating copy to clipboard operation
redis-ratelimit copied to clipboard
verified publisher icon hamsterready

Calls in RateLimitService can be externalized to a LUA script

Open hpirosha opened this issue 12 years ago • 2 comments

Hi,

It shall be better off if calls to redis from RateLimitService.java can be combined in a LUA script. That way it shall be faster since redis will compile it once and is invoked via SHA code.

I have put the calls in a script, it is @ https://gist.github.com/hpirosha/8972921

Thanks, Hussain

hpirosha avatar Feb 13 '14 10:02 hpirosha

Hi @hpirosha - we will definitely have a look at that. Thanks.

BTW: are you using the implementation in any of your projects (always happy to hear some good stories ;))?

Cheers,

hamsterready avatar Feb 13 '14 21:02 hamsterready

No, Haven't used so far. Appreciate that you open sourced your work.

On Fri, Feb 14, 2014 at 3:08 AM, Maciej Lopacinski <[email protected]

wrote:

Hi @hpirosha https://github.com/hpirosha - we will definitely have a look at that. Thanks.

BTW: are you using the implementation in any of your projects (always happy to hear some good stories ;))?

Cheers,

Reply to this email directly or view it on GitHubhttps://github.com/hamsterready/redis-ratelimit/issues/2#issuecomment-35029170 .

hpirosha avatar Feb 17 '14 06:02 hpirosha