Wikimate icon indicating copy to clipboard operation
Wikimate copied to clipboard

Update API URLs to typical path, update other links, and use https

Open Xymph opened this issue 1 year ago • 4 comments

I noticed a few http links now redirect to https, and an extended URL scan pointed to some other links also worth updating.

Xymph avatar Feb 22 '24 16:02 Xymph

Hmm, looks like markdownlint needs to be taught how to accept our changelog.

Xymph avatar Feb 22 '24 16:02 Xymph

Hey @waldyrious, could you please resolve this GH action problem? Thanks.

Xymph avatar Feb 29 '24 10:02 Xymph

Hmm, it seems they changed the configuration of MD024 to only accept siblings_only rather than allow_different_nesting, which is what we used.

We need to change this code:

https://github.com/hamstar/Wikimate/blob/e6d3fdac49ab87f18e96c800658ce32d5eb5b388/.markdownlint.yml#L21-L24

 # MD024/no-duplicate-heading
 MD024:
   # Only check sibling headings
-  allow_different_nesting: true
+  siblings_only: true

Do you want to do that in this PR, or should we make it a separate one?

waldyrious avatar Apr 22 '24 22:04 waldyrious

Welcome back. The clean way would be a separate PR, tbh - unless that's overkill? This PR is kind of a clean-up thingy already... your call.

Xymph avatar Apr 22 '24 22:04 Xymph

@waldyrious The silence has been deafening long enough. :stuck_out_tongue_winking_eye:

I fixed the markdown rule in this PR and merged it per the Governance rule 2 exception.

Xymph avatar Jun 24 '24 13:06 Xymph