Duplicate regex Matcher

[alb-i986]

Hi,

First of all, thanks for bringing this project back to life.

If I'm not mistaken there's a duplication in the regex matchers:

• MatchesPattern
• StringRegularExpression

There were none for such a long time and now there's two LOL I'm not complaining huh, but I think it would be wise to leave only one ;)

Cheers

[tingtron]

More specifically, there are two ways to match regex in test code:

1. org.hamcrest.Matchers.matchesRegex(regexString)
2. org.hamcrest.text.MatchesPattern.matchesPattern(regexString)

They are semantically the same, and mostly similar in implementation.

[nhojpatrick]

Yes the classes do appear to be duplicates and cover very similar functionaility;

org.hamcrest.Matchers.matchesRegex(String) basically calls out to org.hamcrest.core.StringRegularExpression

org.hamcrest.core.StringRegularExpression org.hamcrest.text.MatchesPattern

[hakanai]

I also wonder about:

• theInstance(T) vs sameInstance(T)
• any(Class<T>) vs instanceOf(Class<T>)

Also there is a general influx of badly-considered naming, documented here.