Halide icon indicating copy to clipboard operation
Halide copied to clipboard

Change an assert to match code, hopefully.

Open zvookin opened this issue 3 years ago • 1 comments

Ran into this assert. The entire destructuring of For names things has to go, but the code only accesses two elements here and I'm not sure why a two level loop next shouldn't be applicable here.

zvookin avatar Aug 29 '22 19:08 zvookin

This PR has been sitting here for a while -- should it land?

steven-johnson avatar Sep 20 '22 22:09 steven-johnson

Andrew and I agreed that the entire thing being checked here is probably no longer needed. Planning to test that hypothesis and do it on this PR if it works.

zvookin avatar Sep 23 '22 21:09 zvookin

Any update on this PR?

steven-johnson avatar Feb 13 '23 18:02 steven-johnson

Ping for status.

steven-johnson avatar Mar 01 '23 17:03 steven-johnson

I'm testing the hypothesis that the thing being checked is no longer needed. Will report back shortly.

abadams avatar Mar 01 '23 17:03 abadams

Replaced by #7386

abadams avatar Mar 03 '23 20:03 abadams