Halide icon indicating copy to clipboard operation
Halide copied to clipboard

[HVX] Fix state_var issue

Open rootjalex opened this issue 3 years ago • 7 comments

The issue in #6893 is the result of an attempt to dereference a pointer to the module_state pointer. This PR simply adds a runtime method to dereference the pointer, in order to fix that issue. I'm not necessarily sure if this is the best approach, would love feedback from anyone who knows the HVX runtime better than I do.

rootjalex avatar Jul 28 '22 20:07 rootjalex

@pranavb-ca might be able to weigh in

abadams avatar Jul 28 '22 20:07 abadams

LGTM. @aankit-ca can help you test this if you need. (sorry, i am on vacation with limited access to my work machine).

pranavb-ca avatar Jul 29 '22 04:07 pranavb-ca

Thanks for taking a look @pranavb-ca - sorry for bothering you on your vacation!

rootjalex avatar Jul 29 '22 20:07 rootjalex

So how confident are we in this change? Do we have a way to verify that the null-check code is actually being exercised?

steven-johnson avatar Aug 01 '22 17:08 steven-johnson

I don't think we have a way to verify that it is, however this change is actually safer - the current version in main will just load without the nullptr check.

rootjalex avatar Aug 01 '22 19:08 rootjalex

@aankit-ca Any chance you could look at this? #6884 is stalled until this PR goes through

rootjalex avatar Aug 02 '22 16:08 rootjalex

Monday review ping to @aankit-ca

steven-johnson avatar Aug 08 '22 19:08 steven-johnson

bump

rootjalex avatar Aug 16 '22 15:08 rootjalex

If @aankit-ca isn't available for this review, we should either find someone else or just land it as-is.

steven-johnson avatar Aug 18 '22 16:08 steven-johnson