asdf-java icon indicating copy to clipboard operation
asdf-java copied to clipboard

Use user home to integrate java for macOS

Open rennsax opened this issue 1 year ago • 2 comments

Fix #213.

To integrate jdk at user home, set java_macos_integration_in_home = yes.

rennsax avatar Feb 26 '24 09:02 rennsax

@rennsax Thanks for the effort!

A few points to consider:

  • Add some documentation (to the README.md I'd guess)

    • similarly to the java_macos_integration_enable option
  • Add tests (to the .github/workflows/tests.yml I'd guess)

    • This can ensure that a later feature / change does not break what You'd done
  • I think You almost nailed the naming for the option:

    • starts with java_macos_integration_ - cool
    • however, I'd prefer if it was java_macos_integration_user_home

I hope the maintainer (@halcyon) should be able to help You with these, until then I'll try to test it locally, and give You feedback if I encounter some issues.

mrmeszaros avatar Apr 09 '24 23:04 mrmeszaros

@mrmeszaros Thanks for your advices! I may struggle some time to deal with the tests.

rennsax avatar May 05 '24 17:05 rennsax