glsl::syntax::StructSpecifier::fields should use NonEmpty instead of Vec

Open hadronized opened this issue 8 years ago • 3 comments

Aug 30 '17 14:08 hadronized

Hi, I would like to help with this project. Can you explain this issue a little more? I mean, How does this improve code? NonEmpty is just an alias to vec? is it enforcing the constraint somehow that I can not see?

Oct 14 '17 07:10 LuisAyuso

Currently, it’s just an alias, yes. It’s not perfect – as in Haskell’s data NonEmpty a = a :| [a], but it’s something. I’ll edit the issue to make it clear what is needed. ;)

Oct 14 '17 11:10 hadronized

#30

Oct 14 '17 13:10 LuisAyuso