haddock3 icon indicating copy to clipboard operation
haddock3 copied to clipboard

implement `topocg` module and helper functions

Open rversin opened this issue 1 year ago • 1 comments

You are about to submit a new Pull Request. Before continuing, make sure you read the contributing guidelines and that you comply with the following criteria:

  • [x] You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • [x] Your PR is about CNS
  • [ ] Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • [ ] You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • [ ] Your code follows our coding style
  • [ ] You wrote tests for the new code
  • [ ] tox tests pass. Run tox command inside the repository folder
  • [ ] -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • [ ] PR does not add any dependencies, unless permission granted by the HADDOCK team
  • [x] PR does not break licensing
  • [ ] Your PR is about writing documentation for already existing code :fire:
  • [ ] Your PR is about writing tests for already existing code :godmode:

rversin avatar Sep 06 '24 13:09 rversin

Should probably not be gzipped as they will be used later on in the cg-to-aa module

amjjbonvin avatar Sep 07 '24 18:09 amjjbonvin

This is currently at +5,566 lines and I assume you are not close to being done, please break it down into smaller PRs

rvhonorato avatar Sep 25 '24 14:09 rvhonorato

Or - so we make subbranches of the topocg branch and merge every time into the topocg branch, which we should rename to CG-HADDOCK for example

amjjbonvin avatar Sep 25 '24 14:09 amjjbonvin