vscode-ocaml icon indicating copy to clipboard operation
vscode-ocaml copied to clipboard

Plan to move from merlin 2 to merlin 3

Open hackwaly opened this issue 8 years ago • 5 comments

hackwaly avatar May 29 '17 01:05 hackwaly

The current version of merlin (github/master, not yet released) now also compiles on Windows. So, from my point of view it would make sense to think about support of merlin 3. Unfortunately, the legacy mode of merlin 3 does not work with vscode-ocaml today. I have no experience with vscode extensions, but I can support with testing, especially on Windows.

kkirstein avatar Aug 29 '17 06:08 kkirstein

Unfortunately, the legacy mode of merlin 3 does not work with vscode-ocaml today.

Does not work with vscode-ocaml on windows you mean? I'm using vscode-ocaml and merlin 3 on linux since a few days without trouble.

Khady avatar Aug 29 '17 07:08 Khady

@Khady Thanks for the feedback. Yes, I am using it on Windows (cygwin environment with mingw toolchain for ocaml). Merlin 3 works with vim, but not with vscode, so I concluded it to be a vscode issue. Maybe that was a hasty conclusion... Did you specify any command line parameter via "ocaml.merlinPath"?

kkirstein avatar Aug 29 '17 07:08 kkirstein

No, I have no special configuration. And I changed nothing in my vscode configuration when I upgraded to merlin 3.

Unfortunately I don't have a windows to try to reproduce the problem.

Khady avatar Aug 29 '17 07:08 Khady

@kkirstein Yes. Merlin 3 says it support legacy protocol, but on windows it's buggy. Vim seems use new protocol, thus it works. see https://github.com/hackwaly/vscode-ocaml/issues/112#issuecomment-324861476

hackwaly avatar Aug 29 '17 08:08 hackwaly