hackerAPI
hackerAPI copied to clipboard
Allow for Multi Select Pronoun Field
Tickets:
- HAC-
List of changes:
- Some people use multiple sets of pronouns (ex. they/he, she/they, she/he, etc.), this change allows people to select multiple from the dropdown
- Changed "pronoun" field from type string to type String[] along with relevant validators
Type of change
Please delete options that are not relevant.
- [ ] New feature (non-breaking change which adds functionality)
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- tested locally with corresponding dashboard changes
Test Configuration:
Firmware version: Hardware: Toolchain: SDK:
Questions for code reviewers?
- anything I'm missing to ensure backwards compatibility with when pronouns were just a string? I don't think so, but I wanna double check. I believe that is just handled in the frontend and nothing here
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] My changes generate no new warnings
- [ ] Listed change(s) in the Changelog
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have made corresponding changes to the documentation
- [ ] Any dependent changes have been merged and published in downstream modules
@janekhuong good catch! will fix
@janekhuong take a look now ?