[Feature Request] Store token in safe place like keychain

Open khanhicetea opened this issue 7 years ago • 3 comments

Hi, thanks for creating this awesome app !

Currently, Lepton save Github access token in User Data storage as plain text (macOS : ~/Library/Application\ Support/Lepton/storage/token.json)

Could we store sensitive data inside keychain of OS ?

I recommend using this lib : https://github.com/atom/node-keytar

Oct 01 '18 14:10 khanhicetea

That's a good call! Would you mind sending a PR for that given you have done some research in this area?

Oct 02 '18 03:10 hackjutsu

I'm a newbie JS developer. But I will try my best to make a PR for this feature :)

Oct 02 '18 04:10 khanhicetea

I made a PR, please help me on review code (sorry for bad code b/c I'm new in JS and Electron) :)

Thank you very much !

Oct 02 '18 11:10 khanhicetea