website icon indicating copy to clipboard operation
website copied to clipboard

Updated Links Variable for Github

Open abinetabate1 opened this issue 2 months ago • 6 comments

When this PR is ready to be merged. This has to be done at the Monday 5pm Pacific meeting between Dev/PM. Please link the PR in that agenda issue under new items

  • https://github.com/hackforla/website/issues/7859
    • Bonnie will change the ops repo name to devops and then merge the PR.

Fixes #8389

What changes did you make?

  • the links variable for github was updated to point to https://github.com/hackforla/devops instead of https://github.com/hackforla/ops

Why did you make the changes (we will use this info to test)?

  • devops repo is being renamed from "https://github.com/hackforla/ops" to "https://github.com/hackforla/devops" with this change users will be able to navigate to the renamed repo from the hfla website's communities of practice page: "https://www.hackforla.org/communities-of-practice"

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • [x] I have checked this PR for CodeQL alerts and none were found.
  • [ ] I found CodeQL alert(s), and (select one):
    • [ ] I have resolved the CodeQL alert(s) as noted
    • [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

note: hovering over button does not show link url in chrome or edge browser. Including screenshot of chrome dev tools view of page to show the change that was made.

Visuals after changes are applied

abinetabate1 avatar Nov 22 '25 04:11 abinetabate1

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b abinetabate1-update-cop-devops-github-link-8389 gh-pages
git pull https://github.com/abinetabate1/website.git update-cop-devops-github-link-8389

github-actions[bot] avatar Nov 22 '25 04:11 github-actions[bot]

Review ETA: 6pm 11/23/2025 Availability: 5-8 PM Sunday

ldaws003 avatar Nov 23 '25 07:11 ldaws003

Review ETA: 9:30 AM 11/23 Availability: 9:30 AM - 11:00 AM, 11/23

izzy-me avatar Nov 23 '25 17:11 izzy-me

Hi @abinetabate1! Great work on this PR.

Done Correctly:

  • Merge branches correctly set
  • Issue is correctly linked
  • PR title is properly named
  • code changes are correct and appropriate
  • correctly assigned yourself and the status of the project
  • action items have been checked off

Requested Changes:

  • make sure to include a before and after screenshot of the website itself, not the inspected code for the website. If this isn't possible for whatever reason, please make note of it in the comments. I believe if you hover your mouse over the "View Github" button under DevOps on the communities of practice page, you should be able to see the change in your Docker environment.

Overall, great work! Thanks for taking up this issue

@izzy-me - hovering mouse over "View Github" does not show the change I made. I have added a note as per your suggestion.

abinetabate1 avatar Nov 23 '25 18:11 abinetabate1

Hey @abinetabate1. Good work on this PR. The branches

Done Correctly:

  • Branch was correctly named
  • Issue is linked
  • PR merge branch is correct
  • PR title is appropriate
  • code changes are exactly as requested
  • correctly assigned yourself and the status of the project
  • action items have been checked off
  • PR is mostly correct

Requested Changes:

  • Please remove the images of the code in the before and after screenshots. For any changes that cannot be shown in the UI, it is best to not include any screenshots and to put an explanation of why your code changes wouldn't result in a change in the website's looks.

Overall, great work! Thanks for taking up this issue

@ldaws003 - your requested change is not necessary. Issue asks to include screenshot. Plus I do not necessarily agree with your statement “For any changes….” Please approve or we can escalate to lead.

abinetabate1 avatar Nov 24 '25 01:11 abinetabate1

@abinetabate1 thanks for working on this issue, all looks good! Since it requires Bonnie to merge this PR, I went ahead and closed the original issue so you can move on to working on your next issue without waiting.

daras-cu avatar Nov 25 '25 03:11 daras-cu