website icon indicating copy to clipboard operation
website copied to clipboard

Remove Kristen Cardon from leadership section

Open praytoo opened this issue 7 months ago • 14 comments

Fixes #8010

What changes did you make?

  • Removed Kristen Cardon from leadership section
  • This PR removes Kristen Cardon from the leadership section in _projects/website.md as instructed in issue #8010.

Why did you make the changes (we will use this info to test)?

  • Kristen Cardon was no longer needed in the leadership section

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • [x] I have checked this PR for CodeQL alerts and none were found.
  • [ ] I found CodeQL alert(s), and (select one):
    • [ ] I have resolved the CodeQL alert(s) as noted
    • [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image Screen Shot 2025-06-24 at 11 17 23 AM

Visuals after changes are applied

image Screen Shot 2025-06-24 at 2 56 08 PM

praytoo avatar Jun 19 '25 03:06 praytoo

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b praytoo-remove-kristen-cardon gh-pages
git pull https://github.com/praytoo/website.git remove-kristen-cardon

github-actions[bot] avatar Jun 19 '25 03:06 github-actions[bot]

Availability: Mon-Sat after 6pm PST ETA: 6/20/2025

FatCatLikesBeer avatar Jun 19 '25 06:06 FatCatLikesBeer

Hi @FatCatLikesBeer 👋 Thanks again for the feedback!

  • [x] I have reviewed the CodeQL Alerts and confirmed there are no issues.
  • [x] Added requested screenshot(s) for visual confirmation.

✅ Visual Confirmation

Before

Screen Shot 2025-06-18 at 8 01 23 PM

After

Kristen Cardon has been removed from the leadership section as intended. Screen Shot 2025-06-18 at 8 04 47 PM

praytoo avatar Jun 20 '25 16:06 praytoo

Hi @praytoo -- I think @FatCatLikesBeer is saying you should include screen caps of the visual changes to the website, not snips of changes to your code. Also, the screen captures should be included as part of the main PR description rather than in a comment.

You can see on the currently hosted version of the HfLA website project page that Kristen's card is present under project leadership. With your change, Kristen's card should be removed, and we want the PR description to show the before/after. To be able to see the effect of your code change before it is integrated into the official HfLA codebase, you will need to serve the page locally on your machine -- steps to do that are in CONTRIBUTING.md. If you can do that, you'll be able to confirm your changes work locally before they're merged, and grab before/after screenshots easily

Please reach out if you need any help!

ryanfkeller avatar Jun 20 '25 17:06 ryanfkeller

Hi @praytoo , thank you for the quick turn around!

A couple clarifications, in my previous comment, I made a mistake when saying your "pull request comment". I should have said your "pull request post". I've updated my comment to reflect that.

The expected screenshots are of the website itself, not screenshots of the code. An example can be found here #8116 at the bottom the post (click the little triangle thingies).

Again, thank you for the quick response, and thank you for your hard work! 💪🏽

FatCatLikesBeer avatar Jun 20 '25 17:06 FatCatLikesBeer

Hi @ryanfkeller @FatCatLikesBeer im running into an issue when I try to run Jekyll to visit the local site the error says I have @import “main” in the file and $absolute_url: “{{ site.url }}”; in the file and that's causing the error but when I initially got the error I deleted it from the file…but like I said the error persists even after I’ve deleted those commands and replaced it with @use "../../_sass/main":, can you help me trouble shoot this issue so I can post the screenshots of the site? Thank you image

praytoo avatar Jun 21 '25 17:06 praytoo

Hi @praytoo -- you shouldn't need to execute Jekyll manually from the command line like it seems you are doing. Have you read and tried the steps in CONTRIBUTING.md* to serve the website? If so, let me know which step got you stuck.

If not, you'll probably want to revert the non-PR related local changes you made (i.e., restore the file you deleted and undo other changes), then try launching the Jekyll server with docker. The server should dynamically detect code changes and update your locally hosted the website as you go.

*Note that you may need to use docker compose up, rather than docker-compose up.

ryanfkeller avatar Jun 21 '25 18:06 ryanfkeller

Okay I'll give this a go once I'm back at my laptop and I'll update you as I go thank you @ryanfkeller

praytoo avatar Jun 21 '25 18:06 praytoo

Hi @ryanfkeller — I’ve been trying to follow the Docker workflow to serve the site locally, but I keep running into persistent gem and bundler errors inside the container.

I’ve tried:

  • docker compose down -v and build --no-cache
  • Deleting and regenerating Gemfile.lock
  • Installing gems (rake, bundler 2.6.9) manually inside the container
  • Running bundle install directly in /srv/jekyll

But I'm still getting errors like Bundler::GemNotFound: Could not find gem 'jekyll (~> 4.4.0)'.

Would love guidance on next steps to get the site running with Docker so I can provide the before/after screenshots.

Thank you

praytoo avatar Jun 22 '25 01:06 praytoo

Hi @praytoo,

Sorry for the trouble you're having! I think you're headed down the right path with docker compose down -v and build --no-cache.

The Bundler::GemNotFound: Could not find gem 'jekyll (~> 4.4.0)' error is unusual because the Docker container should handle all dependencies automatically. I see you mentioned removing Gemfile.lock, which was a good call. However, if you ran Jekyll outside the container, it may have generated other Jekyll artifacts in your local filesystem (like the _site/ build directory, .jekyll-metadata cache file, or potentially .jekyll-cache/) that can still conflict with the container's setup.

When you run docker compose up, these remaining local files get mounted into the container and can override the working setup. Since these files live in your local directory, they persist through docker compose down -v and build --no-cache - those commands can't fix files on your host filesystem.

If this seems possible, my recommendation would be to:

  1. Make sure all your local changes are pushed up to your fork
  2. Create a fresh clone of your website repository
  3. Re-try serving the website from that new clone via docker compose up

This would preserve your actual work while eliminating any local Jekyll artifacts, and hopefully should resolve the gem dependency issue since the container will start in a clean environment.

Let us know how this goes, and please reach out here or on slack if you run into issues, or if this doesn't work! Local environment setup is all part of the fun...

ryanfkeller avatar Jun 24 '25 15:06 ryanfkeller

hello @FatCatLikesBeer ive updated my original post to reflect the requested before and after screenshots!

praytoo avatar Jun 24 '25 22:06 praytoo

Thank you @FatCatLikesBeer it was my first ever issue, glad we made it through, the journey was worth it!

praytoo avatar Jun 25 '25 03:06 praytoo

@ryanfkeller also thank you for your contributions!

praytoo avatar Jun 25 '25 03:06 praytoo

Review ETA: 6 PM 6/26/25 Availability: 10-6 PM Wednesday, Thursday

nubilaxl avatar Jun 25 '25 17:06 nubilaxl

Thank you @nubilaxl ! It was my first issue ever so I'm happy you liked it!

praytoo avatar Jun 26 '25 16:06 praytoo

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

mugdhchauhan avatar Jun 27 '25 15:06 mugdhchauhan