website icon indicating copy to clipboard operation
website copied to clipboard

Adding test instructions and links to CONTRIBUTING.md #7762

Open aswutmaxcy opened this issue 7 months ago • 6 comments

Fixes #7762

What changes did you make?

  • Added test instruction and links to section 2.7 and 2.7b

Why did you make the changes (we will use this info to test)?

  • For Reviewers: Do not review changes locally, rather, review changes at (https://github.com/aswutmaxcy/website/blob/add-test-contribute-7762/CONTRIBUTING.md)
  • to add a section to explain testing and the importance of it

CodeQL Alerts

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • [x] I have checked this PR for CodeQL alerts and none were found.
  • [ ] I found CodeQL alert(s), and (select one):
    • [ ] I have resolved the CodeQL alert(s) as noted
    • [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

aswutmaxcy avatar Jun 18 '25 21:06 aswutmaxcy

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aswutmaxcy/website/blob/add-test-contribute-7762/CONTRIBUTING.md  

github-actions[bot] avatar Jun 18 '25 21:06 github-actions[bot]

Availability: after 1pm (pacific) ETA: 6/25

kdaca19xx avatar Jun 22 '25 17:06 kdaca19xx

Availablity: After 5pm PST ETA: 6/25 end of day

xnealcarson avatar Jun 23 '25 20:06 xnealcarson

@kdaca19xx Thank you so much for going through this with a fine tooth comb and finding the mistakes, I totally blanked on these! I just made all the changes you suggested and @t-will-gillis I also implemented the changes you suggested as well. Thank you both for taking the time to find these mistakes.

aswutmaxcy avatar Jun 25 '25 18:06 aswutmaxcy

@t-will-gillis whoops! I'm a dumb, I just pushed the changes, it's up now

aswutmaxcy avatar Jun 25 '25 21:06 aswutmaxcy

Availability: after 1pm (pacific) ETA: 6/25

New ETA: 6/26 (Thx for your changes and patience @aswutmaxcy !)

kdaca19xx avatar Jun 25 '25 23:06 kdaca19xx

@t-will-gillis thank you for the catch! I just pushed the changes

aswutmaxcy avatar Jul 01 '25 19:07 aswutmaxcy

@t-will-gillis If I messed it up again this time, I give you permission to burn my computer

aswutmaxcy avatar Jul 02 '25 16:07 aswutmaxcy

PR has two previous reviews and Approvals, OK to merge.

t-will-gillis avatar Jul 02 '25 16:07 t-will-gillis