website icon indicating copy to clipboard operation
website copied to clipboard

Update to "Schedule Monthly" workflow

Open t-will-gillis opened this issue 1 year ago • 1 comments

Overview

The "Schedule Monthly" workflow[^1] currently does not account for the July break, so devs who do not contribute during the month will be listed as "inactive" by the bot and potentially removed. We want the workflow to account for the July break.

Action Items

  • [ ] In schedule-monthly.yml[^2] , adjust the cron job to account for the July break by skipping the currently scheduled run on August 1st:

        - cron:  0 11 1 2-7,9-12 *
    
  • [ ] Same file, update the comment near line 3:

    # This action runs at 11:00 UTC/ 4:00 PDT on the first day of every month except January and September.
    
  • [ ] In get-contributors-data.js[^3] lines 16 and 17, the variables oneMonth and twoMonths are set to "2" and "3" respectively on the February 1st run to account for the December break. Add the same logic for the September 1st run to account for the July break. Replace:

    // Set date limits: we are sorting inactive members into groups to warn after 1 month and remove after 2 months.
    // Since the website team takes off the month of December, the January 1st run is skipped (via `schedule-monthly.yml`).   
    // The February 1st run keeps the 1 month inactive warning, but changes removal to 3 months inactive (skipping December).
    let today = new Date();  
    let oneMonth = (today.getMonth() == 1) ? 2 : 1;            // If month is "February" == 1, then oneMonth = 2 months ago
    let twoMonths = (today.getMonth() == 1) ? 3 : 2;           // If month is "February" == 1, then twoMonths = 3 months ago
    

    with:

    // Set date limits: we are sorting inactive members into groups to notify after 1 month and remove after 2 months.  
    // Since the teams take off December and July, the Jan. 1st and Aug. 1st runs are skipped (via `schedule-monthly.yml`). 
    // The Feb. 1st and Sept. 1st runs account for skipped months: 'oneMonth' & 'twoMonths' = 2 & 3 months respectively
    let today = new Date();
    let oneMonth = (today.getMonth() === 1 || today.getMonth() === 8) ? 2 : 1;
    let twoMonths = (today.getMonth() === 1 || today.getMonth() === 8) ? 3 : 2;
    
  • [ ] NOTE: Although this file is a GitHub Action, testing is not required for this issue.

Resources/Instructions

[^1]: "Schedule Monthly" and "WR-Schedule Monthly" wiki [^2]: schedule-monthly.yml [^3]: get-contributors-data.js

t-will-gillis avatar Jul 01 '24 04:07 t-will-gillis

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jul 01 '24 05:07 github-actions[bot]

Hi @mSharifHub, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jul 15 '24 01:07 github-actions[bot]

Hi @mSharifHub Un-assigning you from this issue because it appears that you still need to complete two good first issues. If you believe this is an error, let me know which issues you have completed. Otherwise please complete two good first issues before working on issues with greater complexity.

Update: @mSharifHub FYI issues #7102 and #7103 are currently available.

t-will-gillis avatar Jul 15 '24 18:07 t-will-gillis

Hi @melissam640, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jul 15 '24 21:07 github-actions[bot]

i. Availability: M-F ii. ETA: EOD

melissam640 avatar Jul 15 '24 21:07 melissam640

sounds good. Assigned to one of the first good issues

On Sun, Jul 14, 2024 at 6:41 PM github-actions[bot] < @.***> wrote:

Hi @mSharifHub https://github.com/mSharifHub, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

— Reply to this email directly, view it on GitHub https://github.com/hackforla/website/issues/7083#issuecomment-2227578654, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAIFC5BIP5XZNK4Y7FAICFLZMMSFDAVCNFSM6AAAAABKEZKOG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGU3TQNRVGQ . You are receiving this because you were mentioned.Message ID: @.***>

mSharifHub avatar Jul 15 '24 23:07 mSharifHub