website icon indicating copy to clipboard operation
website copied to clipboard

Update CONTRIBUTING.md Section 2.7.d

Open DrAcula27 opened this issue 1 year ago • 4 comments

Dependency

  • #6581

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

When following the instructions in CONTRIBUTING.md, step 2.7.d is ambiguous. This step needs to be clarified.

Action Items

  • [x] In your local IDE, navigate to CONTRIBUTING.md
  • [x] Replace
#### **2.7.d Working on an issue (4): Pulling from upstream before you push**

**IMPORTANT:** Before you push your local commits to your repository, sync your fork to the main Hack For LA website repository. `git pull upstream` will ensure that your local repository is up-to-date with the main site:

    ```bash
    git pull upstream gh-pages
    ```

You can also sync your fork directly on GitHub by clicking "Sync Fork" at the right of the screen and then clicking "Update Branch"

<details>
  <summary><strong>Click here</strong> to see how to sync the fork on GitHub</summary>
  <img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />
</details>

with

#### **2.7.d Working on an issue (4): Pulling from upstream before you push**

**IMPORTANT:** Before you push your local commits to your repository, sync your fork to the main Hack For LA website repository. You can sync your fork directly on GitHub by clicking "Sync Fork" at the right of the screen and then clicking "Update Branch":

<details>
  <summary><strong>Click here</strong> to see how to sync the fork on GitHub</summary>
  <img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />
</details>

Next, bring upstream changes into your topic branch. With your topic branch checked out, run: 

    ```bash
    git pull upstream gh-pages
    ```
  • [x] With CONTRIBUTING.md still open, make a note of the section in which the replaced content appears, so that you will know where to look in the document to preview the change.
  • [x] Changes to CONTRIBUTING.md cannot be tested locally, rather they must be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL. Also store the test URL for use in a later step:
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/bonniewolfe/website/blob/issue-branch-1234/CONTRIBUTING.md)

  • [x] Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.
For Reviewers: Do not review changes locally, rather, review changes at [REPLACE WITH TEST URL]

Resources/Instructions

DrAcula27 avatar Jun 21 '24 02:06 DrAcula27

Hi @DrAcula27, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jun 21 '24 02:06 github-actions[bot]

Hi @patelbansi3009, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jun 26 '24 19:06 github-actions[bot]

Issue completion ETA is End of 06/25/24.

patelbansi3009 avatar Jun 26 '24 20:06 patelbansi3009

Hi @patelbansi3009, I'm unassigning you from this issue as it's not ready to be worked on until the dependency is satisfied. It appears you may have self-assigned this from the Ice Box column. As a reminder:

  • Issues in the "Ice Box" or "New Issue Approval" columns are not ready for development.
  • Please only work on and self-assign issues from the "Prioritized backlog" column.

Thanks for your understanding!

jphamtv avatar Jun 27 '24 18:06 jphamtv

Hi @melissam640, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

HackforLABot avatar Jul 18 '24 19:07 HackforLABot

i. Availability: M-F ii. ETA: EOD tomorrow (7/19)

melissam640 avatar Jul 18 '24 19:07 melissam640