website icon indicating copy to clipboard operation
website copied to clipboard

Update Team Meeting data on the Events page to show meeting frequency

Open Thinking-Panda opened this issue 1 year ago • 18 comments

Overview

Currently the Online Project Team Meeting section of Events page has Day, Start Time, End Time, Name of Project, and Name of Meeting. As some of the meetings do not happen weekly (like Onboarding), we need to mark those meetings and add a message to visit project page for more information.

Action Items

  • [x] Analyze and understand the data in _data/external/vrms_data.json
  • [x] Update Team Meeting data on the Events page to add asterisk to the end of "Name of Meeting" if it's not weekly.
  • [x] Add the following text to the end of the "Online Project Team Meetings" section.
    *This meeting is not weekly, check project link for more details.
    
  • [x] Using Docker, check the changes on your local machine

Resources/Instructions

Thinking-Panda avatar May 31 '24 20:05 Thinking-Panda

Hi @colin-macrae, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jun 03 '24 02:06 github-actions[bot]

Availability: Evenings ETA (updated): Th, Jun 13th.

colin-macrae avatar Jun 03 '24 05:06 colin-macrae

@colin-macrae Thank you for working on this issue. Please move the issue to the "In progress" column on the project board.

Thinking-Panda avatar Jun 03 '24 18:06 Thinking-Panda

Hi @Thinking-Panda - What's the best way for me to find out the frequency of meetings (in order to find out which ones are not weekly). I didn't see anything about frequency in the json data nor on the meeting pages. Many thanks, Colin

colin-macrae avatar Jun 07 '24 03:06 colin-macrae

@colin-macrae The meeting frequency is mentioned under "description" in the JSON file.

Thinking-Panda avatar Jun 07 '24 19:06 Thinking-Panda

Hi @Thinking-Panda , thank you! Many of those "description" properties have no values, and many don't mention anything about frequency. So, here is what I'll do, and please do let me know if I should do differently:

  • For all empty values for "description", I will do nothing
  • For all which do not explicitly say meetings are not weekly, I will do nothing
  • For all which explicitly say meetings are not weekly, I will make the requested changes (asterisk etc..)

Does that sound right? Thanks again, Colin

colin-macrae avatar Jun 07 '24 22:06 colin-macrae

Hi @colin-macrae , that's right. The key "description" has a value only when the meeting is not weekly.

Thinking-Panda avatar Jun 10 '24 20:06 Thinking-Panda

Hi @Thinking-Panda - Okay, and just to be extra sure, the event in the pic below is not weekly since the description key has a value (even though there is no mention of frequency). I'll make the prescribed changes to all which are like this one, and no changes to those with no values. Pls kindly confirm. Many thanks!

image

colin-macrae avatar Jun 11 '24 04:06 colin-macrae

@colin-macrae the "description" in line 210 is not the description of the event. It is the description of the project. Scroll a little further to see the event description with no value. Hope this helps.

Thinking-Panda avatar Jun 11 '24 17:06 Thinking-Panda

@Thinking-Panda , got it! So many descriptions for each object 🤣. I see that now, and thanks for your patience. ETA is before Thursday (will update above). Thanks again!

colin-macrae avatar Jun 12 '24 01:06 colin-macrae

Unfortunately I had to unassign myself from this issue for a couple of reasons.

First, I have not used the technologies required to complete the issue and either A) the instructions were a bit vague or B) my inexperience with the site, this file system, and this frontend tech represented a blocker. I tried to get help through dev office hours on Thursday but there was no one there while I waited, from 7-7:10pm. Aside from that I'm traveling out of the country in a couple days and I wouldn't be able to revisit it after today, probably for a few weeks.

I'll look for another issue to pick up, explore moving to a React project, and review some PRs. Many thanks.

colin-macrae avatar Jun 14 '24 02:06 colin-macrae

@Thinking-Panda , if you want to add these to the issue action items, it could prevent a lot of double work. I've compiled the the list of teams whose meetings are not weekly (by looking throgh all the vrms_data.json file), despite not making changes to the code:

onboarding - new prosp. members home unite us - all civic tech jobs - all civic tech jobs - pm/org food oasis - all la tdm calculator - stakeholder food oasis - uxr team 311 data - leads expunge assist - all expunge assist - pm/org civic tech jobs - leads

colin-macrae avatar Jun 14 '24 04:06 colin-macrae

Hi @terrencejihoonjung, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jun 15 '24 05:06 github-actions[bot]

ETA: 6/17/24, 11:59pm PST Availability: 7pm - 12am PST, everyday

terrencejihoonjung avatar Jun 15 '24 05:06 terrencejihoonjung

  1. Progress: I've modified the JSON file to include a "isWeekly" key with their corresponding boolean value. I've also implemented conditional rendering of the asterisk depending on whether isWeekly is false.
  2. Blockers: I'm having some issues with isWeekly showing up as "undefined" even though the JSON file is valid and contains the appropriate data. My docker is also displaying the website in the incorrect format, so I will have to go to office hours to fix that u
  3. Availability: 7pm - 12am PST, everyday
  4. ETA: 6/21/24, 11:59pm PST

terrencejihoonjung avatar Jun 17 '24 05:06 terrencejihoonjung

Reopening this issue: The previous solution relies on direct edits to vrms-data.json. These edits are over-written by the daily workflow run of "Update VRMS Data".

t-will-gillis avatar Jul 02 '24 04:07 t-will-gillis

@terrencejihoonjung Please let us know if you would like to keep working on this issue- thanks!

t-will-gillis avatar Jul 02 '24 04:07 t-will-gillis

updated ETA: 7/3/24, 11:59pm PST updated availability: 7pm - 12am PST, weekdays

terrencejihoonjung avatar Jul 02 '24 05:07 terrencejihoonjung