website icon indicating copy to clipboard operation
website copied to clipboard
verified publisher icon hackforla

Changed iframe object to object video player

Open Cloid opened this issue 1 year ago • 3 comments

Fixes #6749

What changes did you make?

  • Updated iframe to object video player.

Why did you make the changes (we will use this info to test)?

  • To circumnavigate privacy / video blockers dictated by browsers.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Before Changes image
After Changes image

Cloid avatar May 30 '24 06:05 Cloid

Hey @Cloid

Don't hyperlink the issue number, that's done automatically. The first line should just be: Fixes #6749

Just to clarify, your first line currently is: Fixes [#6749](https://github.com/hackforla/website/issues/6749) when it should just be Fixes #6749

ajb176 avatar May 30 '24 15:05 ajb176

Reviewing this PR. Availability: Friday afternoon, Saturday, Sunday morning, Monday. ETA: by end of Monday.

ha-bach avatar May 31 '24 17:05 ha-bach

@Cloid Please resolve the merge conflict and add an availability and ETA for the requested changes. Thanks!

Thinking-Panda avatar Jun 12 '24 02:06 Thinking-Panda

Hi there, sorry for the delay. I'll finish this by EOD Thursday, 08/01

Cloid avatar Jul 30 '24 03:07 Cloid

@muninnhugin Screen sizing is now fixed for all screen sizes, tested via Firefox/Chrome.

Cloid avatar Aug 08 '24 19:08 Cloid

Reviewing now, should be done by EOD today. Sorry new schedule, I'm really busy during the week now.

ha-bach avatar Aug 10 '24 18:08 ha-bach