website icon indicating copy to clipboard operation
website copied to clipboard

Updating github handle for Bonnie W

Open nssensalo opened this issue 1 year ago • 5 comments

Fixes #6759

What changes did you make?

-Added github handle variable below name

Why did you make the changes (we will use this info to test)?

The greater plan is to replace name and github link with a variable.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

image Note: The update does not show. Even after the suggested docker reset I do not see the code on the page. I'm unclear if I am supposed to. Thanks.

Visuals before changes are applied

image

Visuals after changes are applied

image

nssensalo avatar May 06 '24 00:05 nssensalo

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b nssensalo-github-handle-B-Wolfe-6759 gh-pages
git pull https://github.com/nssensalo/website.git github-handle-B-Wolfe-6759

github-actions[bot] avatar May 06 '24 00:05 github-actions[bot]

ETA: 05/06/24 Availability : Monday-Friday 6pm-9pm

Chrisklangley avatar May 06 '24 03:05 Chrisklangley

ETA: 5/9/24 Availability: Weekday evenings

pdimaano avatar May 06 '24 19:05 pdimaano

Phillip,

Thank you for verifying the webpage would be unchanged after my updates. I could not find that information but I'm going to go back and try to track it down for future issues.

And yes, I forgot to check those boxes this time around, will be sure to stick to my cheat sheet until the process is memorized/more second nature.

Thanks, Nansamba

On Mon, May 6, 2024 at 10:13 PM Philip Dimaano @.***> wrote:

@.**** requested changes on this pull request.

@nssensalo https://github.com/nssensalo Thank you for creating this pull request, I just have a few suggestions for changes to be made before final approval:

For the linked issue, make sure you select the appropriate checkboxes that you have completed prior to creating the pull request. This makes it easier for you and the reviewers to keep track of what steps have already been completed.

The linked issue also states that the webpage appearance should be unchanged after updating the code. According to the Hack for LA website contributing documentation, you do not need to include screenshots if this is the case. You can remove the pre-placed text in the "Screenshots" section and write a statement like "No visual changes to the website."

Please make the appropriate changes and I will continue the review process, thanks!

— Reply to this email directly, view it on GitHub https://github.com/hackforla/website/pull/6821#pullrequestreview-2042075914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUNBSNYYYCD3KMOYHCSHBQ3ZBBPG3AVCNFSM6AAAAABHIFPFKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSGA3TKOJRGQ . You are receiving this because you were mentioned.Message ID: @.***>

nssensalo avatar May 07 '24 14:05 nssensalo

Review ETA: EST 11 PM 5/7/24 Availability: 5-8 PM Wednesday

del9ra avatar May 08 '24 01:05 del9ra

Hi @del9ra,

I've checked off the boxes and removed the images.

Let me know if there are any issues. It's now in the pull request "changes requested" mode.

Thanks, Nansamba

On Tue, May 7, 2024 at 6:47 PM Delgira Dordzhieva @.***> wrote:

@.**** requested changes on this pull request.

HI @nssensalo https://github.com/nssensalo,

  • the pull request is done with the correct branch
  • the Issue is linked properly
  • since no changes were implemented, you can omit screenshots. You are not supposed to see any changes
  • the checkboxes in the issue were not marked off Nice job overall! Please make the necessary changes to the code and I will approve your PR.

— Reply to this email directly, view it on GitHub https://github.com/hackforla/website/pull/6821#pullrequestreview-2044474197, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUNBSN6NPZDSAB26Z75VAHLZBF72JAVCNFSM6AAAAABHIFPFKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBUGQ3TIMJZG4 . You are receiving this because you were mentioned.Message ID: @.***>

nssensalo avatar May 09 '24 21:05 nssensalo