website icon indicating copy to clipboard operation
website copied to clipboard

ER: Section 1.7 appears twice in CONTRIBUTING.md and is not listed in steps of Pre-Work Checklist

Open danvgar opened this issue 2 years ago • 11 comments

Emergent Requirement - Problem

  1. Section 1.7 erroneously appears twice in CONTRIBUTING.md
  2. Section 1.7 is not listed within the Pre-work Template - Developers

Issue you discovered this emergent requirement in

Date discovered

  • Jan 2, 2024

Did you have to do something temporarily

  • [ ] YES
  • [X] NO

Who was involved

  • @roslynwythe

What happens if this is not addressed

  • May prolong future onboardings with clarification questions by attendees

Resources

Recommended Action Items

  • [x] Make a new issue
  • [ ] Discuss with team
  • [ ] Let a Team Lead know

Potential solutions [draft]

  • [ ] Delete first copy of Section 1.7 in CONTRIBUTING.md
  • [ ] Edit copy of item 15 to read Complete steps 1.1 - 1.7 in Part 1: Setting up the development environment within Contributing.md

danvgar avatar Jan 03 '24 05:01 danvgar

Hi @danvgar.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Jan 03 '24 05:01 github-actions[bot]

Hey @roslynwythe, per our call today, I'll go ahead and make this ER into an issue, in similar format to #6187. Let me know if I should go ahead and do the same for the other two ERs I've made this month (#6208, #6209)

danvgar avatar Feb 09 '24 03:02 danvgar

Hi @blaycoder, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Mar 11 '24 02:03 github-actions[bot]

@roslynwythe @danvgar should I go ahead with the potential solutions of this issue

blaycoder avatar Mar 11 '24 03:03 blaycoder

@roslynwythe @danvgar should I go ahead with the potential solutions of this issue

Woops, I never assigned this to myself so forgot about it. Lesson learned!

@blaycoder we need to turn this into a proper issue first before going ahead and solving it. Let me go ahead and create one and assign it to you after

danvgar avatar Mar 11 '24 03:03 danvgar

@blaycoder In the future, only issues listed under Prioritized backlog here should be taken up as issues. :)

danvgar avatar Mar 11 '24 03:03 danvgar

Noted, I will unassign the issue

blaycoder avatar Mar 11 '24 03:03 blaycoder

Noted, I will unassign the issue

Thanks, @blaycoder ! I see this issue was erroneously marked as a good first issue when it likely is more of a Complexity: Small issue. I've updated the labels. Please go ahead and take up a good first issue in the Prioritized backlog instead! Sorry for the confusion!

danvgar avatar Mar 11 '24 03:03 danvgar

Hi @danvgar, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Mar 11 '24 03:03 github-actions[bot]

Alright Thanks

blaycoder avatar Mar 11 '24 03:03 blaycoder

@roslynwythe This has been split into separate issues as we discussed a few weeks ago.

  • #6450
  • #6451
  • #6452

They have been placed in the New Issue Approval column.

Let me know if you want to chat and discuss further

danvgar avatar Mar 11 '24 04:03 danvgar

@danvgar I am moving this issue to the questions column and adding the ready for dev lead label. You should do the same next time you are ready for your issue to be reviewed.

ExperimentsInHonesty avatar Mar 25 '24 21:03 ExperimentsInHonesty

@danvgar I am moving this issue to the questions column and adding the ready for dev lead label. You should do the same next time you are ready for your issue to be reviewed.

@ExperimentsInHonesty Understood, thank you for clarifying the process! I was asking this the past few meetings but was told there aren't any additional steps for me to take

danvgar avatar Mar 25 '24 21:03 danvgar

@roslynwythe This has been split into separate issues as we discussed a few weeks ago.

They have been placed in the New Issue Approval column.

Let me know if you want to chat and discuss further

Hey @danvgar I reviewed the issues above and the first two look good and are ready to go. I've set them up to be prioritized. Great work on them!

For #6452, Section 1.7 isn't relevant to the Pre-work Checklist for Design so I closed that issue and left a comment. Please see that issue for more details.

jphamtv avatar Mar 26 '24 06:03 jphamtv