website icon indicating copy to clipboard operation
website copied to clipboard

Edit credit for Marketing image for redesigned homepage

Open JessicaLucindaCheng opened this issue 3 years ago • 4 comments

Overview

We need to edit a credit for a new image used in the redesigned version of the homepage so that the Credits page is up to date.

Details

From the Homepage Redesign Credits in Figma, here is a screenshot of the credit's information for reference:

Click here to see the screenshot of the Marketing credit in Figma

Action Items

  • [x] Feature Branch: You will be working off a feature branch called feature-homepage-launch. Please follow "Step 1: Create your branch" in How to work off of a feature branch wiki article.
  • [x] For _data/internal/credits/marketing.yml,
    • [x] Change title-link: https://thenounproject.com/iconpai19/collection/business-finance/?i=3154527 to title-link: https://thenounproject.com/search/?q=marketing&i=3154527
    • [x] Change content: icon to content-type: image
    • [x] Change used-in: Home to used-in: Homepage
    • [x] Change alt: 'Marketing Icon' to alt: ''
    • [x] Remove type: icon
  • [x] To update your topic branch, please follow "Step 2: Update your branch with upstream changes" in How to work off of a feature branch wiki article.
  • [x] The pull request created from this issue should be merged into feature-homepage-launch. Please follow "Step 3: Create a pull request" in How to work off of a feature branch wiki article
  • [ ] Once the pull request associated with this issue is approved and merged, please update and edit epic #3130 by
    • [ ] Checking off the dependency for this issue
    • [ ] If all dependencies are checked off, please move issue #3130 to the New Issue Approval column and remove the Dependency label

Resources/Instructions

JessicaLucindaCheng avatar Jul 07 '22 03:07 JessicaLucindaCheng

Hi @JessicaLucindaCheng.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Jul 07 '22 03:07 github-actions[bot]

This issue would usually have the milestone 01. Compliance. However, it's specifically for the homepage launch, which has not happened yet.

JessicaLucindaCheng avatar Jul 07 '22 03:07 JessicaLucindaCheng

Hi @d-perez-8, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Aug 12 '22 15:08 github-actions[bot]

Availability: Friday, Saturday ETA: 1 hour

d-perez-8 avatar Aug 12 '22 16:08 d-perez-8