website icon indicating copy to clipboard operation
website copied to clipboard

Edit content field and remove type field from winner.yml credits file

Open Sparky-code opened this issue 3 years ago • 3 comments

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/winner.yml, do the following:

  • [ ] Change line 4 for the content field from
    content: icon
    
    to
    content-type: image
    
  • [ ] Remove line 11 for the type field
    type: icon
    
  • [ ] Once the pull request associated with this issue is approved and merged, please update and edit epic #2775 by
    • [ ] Checking off the dependency for this issue
    • [ ] If all dependencies are checked off, please move issue #2775 to the New Issue Approval column and remove the Dependency label

Resources/Instructions

  • This issue is tracked in the epic #2775.

File and Code links you will need to work on this issue

  • Directory to find the page in once you have it in your IDE: _data/internal/credits/winner.yml

  • Click on the links below to see the source file code: https://github.com/hackforla/website/blob/7164ec247825adca279d4fd99fa52895335badbb/_data/internal/credits/winner.yml#L4 https://github.com/hackforla/website/blob/7164ec247825adca279d4fd99fa52895335badbb/_data/internal/credits/winner.yml#L11

Sparky-code avatar Feb 23 '22 06:02 Sparky-code

Hi @Sparky-code.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Feb 23 '22 06:02 github-actions[bot]

Hi @jond34, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Oct 12 '22 03:10 github-actions[bot]

i. Availability - i can start working on this this Sunday. I expect to finish this in two weeks, bythe 25th :-)

jond34 avatar Oct 12 '22 03:10 jond34

@jond34 When you start working on an issue please move it to the in progress column. We have done that for you here. Can you also please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

ExperimentsInHonesty avatar Nov 13 '22 18:11 ExperimentsInHonesty

@jond34

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 14, 2022 at 11:19 PM PST.

github-actions[bot] avatar Nov 18 '22 07:11 github-actions[bot]

@jond34

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 21, 2022 at 11:17 PM PST.

github-actions[bot] avatar Nov 25 '22 07:11 github-actions[bot]

Sent @jond34 a message on Slack to see if he responds there.

ExperimentsInHonesty avatar Nov 29 '22 14:11 ExperimentsInHonesty

@jond34

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 28, 2022 at 11:17 PM PST.

github-actions[bot] avatar Dec 02 '22 07:12 github-actions[bot]

Returning this issue to the prioritized backlog

ExperimentsInHonesty avatar Dec 02 '22 21:12 ExperimentsInHonesty

Hi @ychang49265, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Dec 26 '22 23:12 github-actions[bot]

i. Availability: throughout the week/flexible ii. ETA: one day

ychang49265 avatar Dec 27 '22 00:12 ychang49265

Blockers: I've added and committed my changes. However, when i attempt to pull from upstream before I push, I received the alert "You asked to pull from the remote 'upstream', but did not specify a branch. Because this is not the default configured remote for your current branch, you must specify a branch on the command line."

  • Prior to working on this first issue, I created my new branch off the gh-pages branch.
  • When I enter 'git remote -v', my forked version of the repo is the origin and then hackforla/website's repo is the upstream.
  • When i tried 'git pull upstream gh-pages", I receive an alert mentioning I have divergent branches.

ychang49265 avatar Dec 27 '22 00:12 ychang49265

@ychang49265

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, January 2, 2023 at 11:15 PM PST.

github-actions[bot] avatar Jan 06 '23 07:01 github-actions[bot]

@ychang49265 If you have not yet gotten help for the blocker above, please post a message in the Slack channel with a link to your comment. Happy New Year!

ExperimentsInHonesty avatar Jan 09 '23 04:01 ExperimentsInHonesty

@ychang49265

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, January 9, 2023 at 11:16 PM PST.

github-actions[bot] avatar Jan 13 '23 07:01 github-actions[bot]