website icon indicating copy to clipboard operation
website copied to clipboard
verified publisher icon hackforla

GitHub Actions: Review ETA and availability

Open SAUMILDHANKAR opened this issue 4 years ago • 12 comments

Overview

Team members reviewing a PR should add their review ETA and availability (in a comment) at the time of assignment so the team is aware of the timeline and the review process becomes more efficient.

Action Items

  • [x] Review the notes below to understand the GitHub actions architecture we are currently moving towards
  • [x] Please go through the wiki article on Hack for LA's GitHub Actions
  • [x] Analyze and implement if this should be a new job under any of the GitHub action files mentioned in the Architecture notes below or should be in a separate file based on the following:
    • [ ] This job triggers when any reviewer is added to the PR
    • [ ] The comment should address the reviewers as @reviewerusername
    • [ ] The comment should request reviewers to add their review ETA and availability
  • [ ] Make sure other jobs are not affected by this

Checks

  • [ ] Test in your local environment that it works
  • [ ] If a reviewer is added, the comment should be posted in the PR

Resources/Instructions

Never done GitHub actions? Start here! GitHub Complex Workflows doc GitHub Actions Workflow Directory Events that trigger workflows Workflow syntax for GitHub Actions actions/github-script GitHub RESTAPI

Architecture Notes

The idea behind the refactor is to organize our GitHub Actions so that developers can easily maintain and understand them. Currently, we want our GitHub Actions to be structured like so based on this proposal:

  • Schedules (military time) - Schedule Friday 0700 - Schedule Thursday 1100 - Schedule Daily 1100
  • Linters - Lint SCSS
  • PR Trigger - Add Linked Issue Labels to Pull Request - Add Pull Request Instructions
  • Issue Trigger - Add Missing Labels To Issues
  • WR - PR Trigger - WR Add Linked Issue Labels to Pull Request - WR Add Pull Request Instructions
  • WR - Issue Trigger

Actions with the same triggers (excluding linters, which will be their own category) will live in the same github action file. Scheduled actions will live in the same file if they trigger on the same schedule (i.e. all files that trigger everyday at 11am will live in one file, while files that trigger on Friday at 7am will be on a separate file).

That said, this structure is not set in stone. If any part of it feels strange, or you have questions, feel free to bring it up with the team so we can evolve this format!

SAUMILDHANKAR avatar Jan 07 '22 12:01 SAUMILDHANKAR

Hi @SAUMILDHANKAR.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Role, Feature

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Jan 07 '22 12:01 github-actions[bot]

Hi @lilyarj, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jul 22 '22 19:07 github-actions[bot]

Availability: 3 hrs ETA: 7/27?

lilyarj avatar Jul 22 '22 23:07 lilyarj

@lilyarj

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 2, 2022 at 12:20 AM PST.

github-actions[bot] avatar Aug 05 '22 07:08 github-actions[bot]

@lilyarj

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 9, 2022 at 12:20 AM PST.

github-actions[bot] avatar Aug 12 '22 07:08 github-actions[bot]

Hi @lilyarj, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Aug 17 '22 02:08 github-actions[bot]

ETA: 8/20 Availability: 3hrs

lilyarj avatar Aug 17 '22 02:08 lilyarj

@lilyarj

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 23, 2022 at 12:25 AM PST.

github-actions[bot] avatar Aug 26 '22 07:08 github-actions[bot]

Hi @arpitapandya, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Sep 21 '22 14:09 github-actions[bot]

ETA: EOD 2022-09-30 Availability: 6hrs

arpitapandya avatar Sep 21 '22 14:09 arpitapandya

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 27, 2022 at 12:45 AM PST.

github-actions[bot] avatar Sep 30 '22 07:09 github-actions[bot]

Progress: I have added job and .md files for the message. I am working on the script. Blockers: I do not have blockers. Availability: 10 hrs ETA: 2022-10-15

arpitapandya avatar Oct 02 '22 17:10 arpitapandya

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 11, 2022 at 12:39 AM PST.

github-actions[bot] avatar Oct 14 '22 07:10 github-actions[bot]

Progress: Not much progress. Blockers: I do not have blockers. Availability: 10 hrs ETA: 2022-10-25

arpitapandya avatar Oct 17 '22 20:10 arpitapandya

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 25, 2022 at 12:20 AM PST.

github-actions[bot] avatar Oct 28 '22 07:10 github-actions[bot]

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Thursday, October 27, 2022 at 11:57 AM PST.

github-actions[bot] avatar Oct 30 '22 18:10 github-actions[bot]

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, November 1, 2022 at 12:20 AM PST.

github-actions[bot] avatar Nov 04 '22 07:11 github-actions[bot]

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 7, 2022 at 11:21 PM PST.

github-actions[bot] avatar Nov 11 '22 07:11 github-actions[bot]

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 14, 2022 at 11:19 PM PST.

github-actions[bot] avatar Nov 18 '22 07:11 github-actions[bot]

@arpitapandya

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 21, 2022 at 11:17 PM PST.

github-actions[bot] avatar Nov 25 '22 07:11 github-actions[bot]

@arpitapandya please either provide an update or return this issue to the prioritized backlog

ExperimentsInHonesty avatar Nov 29 '22 02:11 ExperimentsInHonesty

@arpitapandya please either provide an update or return this issue to the prioritized backlog

  • Hey @ExperimentsInHonesty sorry, for not leaving feedback.
  • Progress: I have already worked on this issue, I am testing it.
  • Once it's tested locally I will submit PR.
  • No blockers

arpitapandya avatar Nov 29 '22 02:11 arpitapandya

Un-assigning myself as I am unable to focus until the end of December.

arpitapandya avatar Dec 10 '22 00:12 arpitapandya