VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

User search query hook

Open jng34 opened this issue 3 months ago • 7 comments

Fixes #2008

What changes did you make and why did you make them ?

  • replaced search query that originally used useState hook with useContext hook
  • allows users to retain previous search queries when navigating back and forth

Fixes #1999

What changes did you make and why did you make them ?

  • resolved bug that prevented updates to user profiles
  • search queries and profile edits persist when toggling between all searches

Screenshots of Proposed Changes Of The Website

Visuals of applied changes image image image

jng34 avatar Oct 08 '25 03:10 jng34

Hey James, thanks for working on another PR! Would you mind double checking the files you staged and comitted? Some Python changes are in your commited code here.

trillium avatar Oct 08 '25 22:10 trillium

@trillium which particular file(s) are you referring to? I do not see any changes to any Python code.

jng34 avatar Oct 09 '25 02:10 jng34

Weird, I could have sworn I saw python changes related to this PR but I don't see them any longer 🤷‍♂️

trillium avatar Oct 09 '25 02:10 trillium

Discussed with @trillium on the call - this PR is ready to be reviewed :)

JackHaeg avatar Oct 21 '25 02:10 JackHaeg

Added "waiting to merge" label for now, because @jng34 is still working on addressing the persistence of the profile edits (changes to statuses and projects), which will be added to this PR.

JackHaeg avatar Oct 28 '25 01:10 JackHaeg

Issue #1999 has been resolved in the latest commit. Ready for review and merge.

jng34 avatar Oct 31 '25 19:10 jng34

Thanks @jng34! @trillium this PR is ready for your review / merge whenever you have a moment :)

JackHaeg avatar Nov 04 '25 02:11 JackHaeg

@trillium please take a look at this PR when you have a moment :)

JackHaeg avatar Jan 13 '26 03:01 JackHaeg