VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Refactor AdminDashboard component to use Material-UI Typography for h…

Open chukalicious opened this issue 1 year ago • 2 comments

Fixes #1671

What changes did you make and why did you make them ?

  • the task required the change of regular html elements for their MUI equivalents, if applicable. Hence, I imported the Typography component from MUI and implemented it in place of the h1 component in the line 390. I implemented the variant and component properties as "h1".
  • It appears some formatting changes were also performed by my formatting extension.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before
Visuals after changes are applied after

chukalicious avatar Jun 20 '24 00:06 chukalicious

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b chukalicious-1671-update-html-components-to-mui-srccomponentsadmindashboardindexjs development
git pull https://github.com/chukalicious/VRMS.git 1671-update-html-components-to-mui-srccomponentsadmindashboardindexjs

github-actions[bot] avatar Jun 20 '24 00:06 github-actions[bot]

@trillium, @chukalicious, should we add style to fit the header in one line as before? The old style looks better than the new one. Also, we don't need to convert div with texts inside to typography. Is that correct?

For example : <div className="event-header">Current event:</div>

vorleakyek avatar Oct 24 '24 05:10 vorleakyek

@trillium to review and remove linting changes

JackHaeg avatar May 07 '25 18:05 JackHaeg

@trillium Just checking in on this PR review :) Can you please take a look at it when you have a moment and review / remove linting changes as we discussed previously?

JackHaeg avatar May 15 '25 22:05 JackHaeg

Hi @trillium! Just checking in again - when you have a moment this week, can you please review this PR / remove linting changes?

JackHaeg avatar Jun 17 '25 00:06 JackHaeg

Turns out after all that complaining this PR isn't compatible with our repo any longer since changing the extension to .jsx.

Closing and adding the ticket back to the backlog

trillium avatar Jun 17 '25 01:06 trillium