311-data icon indicating copy to clipboard operation
311-data copied to clipboard

Make font types in search and filters modal consistent

Open ryanfchase opened this issue 1 year ago • 1 comments

Overview

We need to make fonts on the search and filters modal consistent so users don't get confused about how the modal works

Action Items

  • [ ] Grab the color, font size, and font weight for "Request Types" in the Search and Filters Modal
  • [ ] Apply that color, font size, and font weight to "Date Range"
  • [ ] Apply that color, font size, and font weight to "Boundaries"

Resources/Instructions

  • Figma design file link
Screenshot before proposed changes

image

Screenshot after proposed changes

[TODO: insert screenshot here]

ryanfchase avatar Sep 07 '24 07:09 ryanfchase

Ready for dev lead. I think it's a "Good First Issue". Happy to add more in-depth instruction if required.

ryanfchase avatar Sep 07 '24 07:09 ryanfchase

Reviewing as dev lead: ETA - 9/8 Time - 12pm PT

traycn avatar Sep 07 '24 18:09 traycn

Updated Action Items with file loc, line, and implementation for "Boundaries" and "Date Range" titles in the search/filter map modal.

Comment on my findings:

Style implementation for each title is inconsistent across the 3 Titles in the modal. To introduce consistency, I've proposed a solution to use the useStyle for each file to be consistent with how the style title "Request Types" is implemented.

IMPORTANT NOTE:

Use style has been deprecated since 2021 and is now Legacy. It is not recommended for use. Link to useStyle docs here.

Issue created to address deprecated @mui/style - https://github.com/hackforla/311-data/issues/1820

traycn avatar Sep 08 '24 22:09 traycn

Updated the description a second-time. Issue previously did not update with the detailed action items points.

traycn avatar Sep 08 '24 23:09 traycn

This ticket has been prioritized and is ready to be picked up 👍

ryanfchase avatar Sep 08 '24 23:09 ryanfchase

Updates have been made: image

Brandoncyu avatar Sep 09 '24 18:09 Brandoncyu

PR has been made: https://github.com/hackforla/311-data/pull/1821

Brandoncyu avatar Sep 09 '24 18:09 Brandoncyu