github-by-stars icon indicating copy to clipboard operation
github-by-stars copied to clipboard

Mishandling repositories with commas in star count

Open PatMyron opened this issue 6 years ago • 0 comments

github-by-stars $ node index.js --author aws-cloudformation --name cfn-python-lint --begin 0 --end 7
  {
    repoUrl: 'https://github.com/mozilla-services/socorro',
    stars: 464,
    forks: 207
  },
  {
    repoUrl: 'https://github.com/aws-quickstart/taskcat',
    stars: 436,
    forks: 84
  },
  {
    repoUrl: 'https://github.com/Yelp/Tron',
    stars: 308,
    forks: 52
  },
  {
    repoUrl: 'https://github.com/nucypher/nucypher',
    stars: 231,
    forks: 82
  },
  {
    repoUrl: 'https://github.com/jpetrucciani/bucketstore',
    stars: 198,
    forks: 11
  },
  {
    repoUrl: 'https://github.com/Crystalnix/omaha-server',
    stars: 139,
    forks: 60
  },
  {
    repoUrl: 'https://github.com/HearthSim/HSReplay.net',
    stars: 123,
    forks: 14
  },
  {
    repoUrl: 'https://github.com/harvard-lil/capstone',
    stars: 84,
    forks: 17
  }
  ...

Missing:

  {
    repoUrl: 'https://github.com/zulip/zulip',
    stars: 10,298,
    forks: 3,098
  },
  {
    repoUrl: 'https://github.com/awslabs/serverless-application-model',
    stars: 5,697,
    forks: 1,375
  }
  ...

https://github.com/dteiml/github-by-stars/blob/f34753e40ab573ac4764d299010e44c953176c82/src/sort.js#L18

PatMyron avatar Aug 18 '19 06:08 PatMyron