sprig icon indicating copy to clipboard operation
sprig copied to clipboard

Thumbnail generation script causes games to crash, causing generation to fail

Open recursiveforte opened this issue 1 year ago • 2 comments

The thumbnail generation script overrides some functions with no-ops when running games. For example, setTune, for games running within the script, is set to () => {}. This causes some thumbnails to fail to generate, as seen below, when the return values of these functions are accessed (in this case: playTune().end()

Screenshot 2024-08-19 at 13 12 29

Relevant file: src/integrations/thumbnail.ts

recursiveforte avatar Aug 19 '24 17:08 recursiveforte

please can you link a game that crashes while a thumbnail is being generated? or even better, provide steps to reproduce

JosiasAurel avatar Aug 20 '24 12:08 JosiasAurel

https://sprig.hackclub.com/gallery/Hey_Hay_Cow The game crashes internally and returns the default confused Orpheus image.

recursiveforte avatar Aug 20 '24 15:08 recursiveforte