hack-chat
Can you add a notification function?
Hi
I just found hack.chat, I love it's minimal and easy to use.
But I can have notification when the message arrived, I have to use another app to notify my friend to watch the message.
Thank you
This functionality does exist ( https://github.com/hack-chat/main/blob/master/client/client.js#L167 ). If you do not get a request to allow notifications from your browser; we will have to narrow down why. First up, what are you running the client on? Any errors listed in the browser console? Can you test using https://www.bennish.net/web-notifications.html so we can narrow down if it's a environmental cause vs our client?
Hi @marzavec Sorry for the delay.
I just try hennish.net on Mac and Win7.
Here's the result
Mac OS 10.15.7 Safari and chrome , test on
Bennish.net notification: Work Sound: Not working
hack.chat notification: not Working Sound: Not working
Win 7 , Chrome
Bennish.net notification: Work Sound: Not working
hack.chat notification: not Working Sound: Not working
I had turn on the notification setting make sure all allowed.
BUT "(Click user to invite) " function's sound and notification both work on Mac chrome(not safari) and Win 7 Chrome.
BTW: Can you make the the setting bar not auto hide?
I had use hack.chat 3days, but never know it had a setting bar.
Can you make the the setting bar not auto hide?
Sure, there is a check box at the top that'll stop it from hiding.
I've had time to test the issue in the same environments that you are using and can confirm the same behavior exists. I'll try to set aside some time to fix it or maybe @Roslot (the one who added the code) would have time? Worse case scenario is that this will have to wait until the feature is added to the new client. . .
@emersonyoung Unfortunately I cannot test notifications on Safari, any code I add in hackchat to support it would be done blind without tests, which doesn't seem like a good idea.
If you're interested in adding support, we can set up a time to communicate on the chat and I can guide you through the process of cloning and setting up the project on your machine, and you can try to make changes to see if it works.
@marzavec I do think it makes more sense to hold off on making too many changes until the new client is online.
From what I understand, there is a new branch version-2-dev that is now available, is this the upcoming new client? I would be interested in seeing, when that's ready, if @emersonyoung would want to switch over.
is this the upcoming new client?
*Thread hijacking noises*
@Roslot Sort of. At the moment, it's just the modified server code, which supports the new engine, which the new client uses. The client itself is just one issue away from being beta ready, but after that there is going to be a large amount of feature addition & bug fixes before it's put into the main repo.
Once the beta client is ready with notifications I'll leave an update on this issue so we can test it.