graphql-sqlalchemy icon indicating copy to clipboard operation
graphql-sqlalchemy copied to clipboard

bug fixes, refactor names

Open beansandmash opened this issue 4 years ago • 2 comments

** merge redundant pk logic into update by pk args and resolver ** fixed issue with delete by pk if row doesn't exist ** fixed issue with update by pk not committing ** fixed issue with update and update by pk if set_/inc_ is not defined ** fixed error generating schema if table does not have an int/float ** refactor names

beansandmash avatar Apr 15 '21 20:04 beansandmash

Codecov Report

Merging #9 (ce9fc56) into master (580e80d) will increase coverage by 32.88%. The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   27.82%   60.71%   +32.88%     
===========================================
  Files          11       11               
  Lines         442      420       -22     
===========================================
+ Hits          123      255      +132     
+ Misses        319      165      -154     
Impacted Files Coverage Δ
src/graphql_sqlalchemy/dialects/pg/inputs.py 0.00% <0.00%> (ø)
src/graphql_sqlalchemy/resolvers.py 25.30% <11.11%> (+10.75%) :arrow_up:
src/graphql_sqlalchemy/inputs.py 88.46% <47.05%> (+66.38%) :arrow_up:
src/graphql_sqlalchemy/names.py 88.23% <83.33%> (+37.17%) :arrow_up:
src/graphql_sqlalchemy/args.py 100.00% <100.00%> (+51.72%) :arrow_up:
src/graphql_sqlalchemy/helpers.py 100.00% <100.00%> (+30.00%) :arrow_up:
src/graphql_sqlalchemy/objects.py 85.71% <100.00%> (+50.00%) :arrow_up:
src/graphql_sqlalchemy/schema.py 100.00% <100.00%> (+72.50%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 580e80d...ce9fc56. Read the comment docs.

codecov-io avatar Apr 15 '21 22:04 codecov-io

Codecov Report

Merging #9 (50af0b5) into master (54a30d0) will increase coverage by 32.78%. The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   27.92%   60.71%   +32.78%     
===========================================
  Files          11       11               
  Lines         444      420       -24     
===========================================
+ Hits          124      255      +131     
+ Misses        320      165      -155     
Impacted Files Coverage Δ
src/graphql_sqlalchemy/dialects/pg/inputs.py 0.00% <0.00%> (ø)
src/graphql_sqlalchemy/resolvers.py 25.30% <11.11%> (+10.75%) :arrow_up:
src/graphql_sqlalchemy/inputs.py 88.46% <47.05%> (+66.38%) :arrow_up:
src/graphql_sqlalchemy/names.py 88.23% <83.33%> (+37.21%) :arrow_up:
src/graphql_sqlalchemy/args.py 100.00% <100.00%> (+51.72%) :arrow_up:
src/graphql_sqlalchemy/helpers.py 100.00% <100.00%> (+30.00%) :arrow_up:
src/graphql_sqlalchemy/objects.py 85.71% <100.00%> (+50.00%) :arrow_up:
src/graphql_sqlalchemy/schema.py 100.00% <100.00%> (+72.50%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54a30d0...50af0b5. Read the comment docs.

codecov-commenter avatar Apr 16 '21 21:04 codecov-commenter