inline-plz icon indicating copy to clipboard operation
inline-plz copied to clipboard

Feature request: Scale per-file comment limit proportionally to diff content

Open raphaelcastaneda opened this issue 7 years ago • 0 comments

Currently, there is a limit of max_comments / 5 for comments in any one file. https://github.com/guykisel/inline-plz/blob/master/inlineplz/interfaces/github.py#L183-L187

If a PR has a ton of change in one file, and not so much in others, it would be nice to allow more comments in that heavily-changed file.

Proposal: calculate the per-file comment limit as: (lines changed in this file / total lines in the diff) * max_comments

raphaelcastaneda avatar Jun 14 '18 17:06 raphaelcastaneda