vim-clojure-highlight icon indicating copy to clipboard operation
vim-clojure-highlight copied to clipboard

Add support for highlighting non-aliased public namespace members.

Open jrdoane opened this issue 7 years ago • 5 comments

For example, allows full names like clojure.core/conj to get highlighted based on namespaces described in (all-ns).

jrdoane avatar Jul 24 '18 17:07 jrdoane

Hi, thanks for the patch! I'll review later this week during the holiday!

guns avatar Jul 02 '19 01:07 guns

Since I made this PR I have actually made some other changes as well with respect to making vim-clojure-highlight work with the latest changes to vim-fireplace. I'm still working out some of the issues, so you might want to hold off on it for the time being. I can branch off the last commit for this particular change if you want.

jrdoane avatar Jul 02 '19 13:07 jrdoane

I submitted an issue on the fireplace project and heard back from Tim Pope and he suggested a different way of doing detection for fireplace, so I've updated my fork. If it looks good to you, have at it.

Just for reference: https://github.com/tpope/vim-fireplace/issues/341

jrdoane avatar Jul 02 '19 17:07 jrdoane

I got Syntax error compiling at (REPL:1:370). No such namespace: vim-clojure-highlight using this branch. It was also very slow on initial load of a namespace, it would be cool if it was async.

SevereOverfl0w avatar Oct 14 '19 11:10 SevereOverfl0w

I got the same error when running :ClojureHighlightReferences. This fixed it error for me:

diff --git a/autoload/vim_clojure_highlight.vim b/autoload/vim_clojure_highlight.vim
index 3492758..1345694 100644
--- a/autoload/vim_clojure_highlight.vim
+++ b/autoload/vim_clojure_highlight.vim
@@ -9,7 +9,7 @@ function! s:session_exists()
 endfunction
 
 function! s:require()
-       if fireplace#evalparse("(find-ns 'vim-clojure-highlight)") ==# ''
+       if fireplace#evalparse("(find-ns 'vim-clojure-highlight)") ==# v:null
                let buf = join(readfile(globpath(&runtimepath, 'autoload/vim_clojure_highlight.clj')), "\n")
                call fireplace#session_eval('(do ' . buf . ')')
        endif

walterl avatar Oct 14 '19 15:10 walterl