DPPy icon indicating copy to clipboard operation
DPPy copied to clipboard

Fix tests

Open stephen-huan opened this issue 11 months ago • 0 comments

Miscellaneous changes to get all the tests working.

  • Missing a np.int -> int conversion (https://github.com/guilgautier/DPPy/issues/75).
  • In numpy 2.0.0, np.complex_ -> np.complex128.
  • Add sum_check=False. (note: this requires scipy>=1.15.0, but that should be ok since it's just for the tests.)

For the last point, see https://github.com/scipy/scipy/issues/12282, https://github.com/scipy/scipy/issues/14298, https://github.com/scipy/scipy/pull/13193, https://github.com/scipy/scipy/pull/21695. I'm not familiar enough with this code to know whether it makes more sense to normalize the sum of the observed frequencies to the sum of the expected frequencies (or the other way around) but they seemed fairly similar so I just disabled the sum check.

stephen-huan avatar Mar 07 '25 06:03 stephen-huan