monkey icon indicating copy to clipboard operation
monkey copied to clipboard

Document styling pattern for UI refactoring

Open VakarisZ opened this issue 2 years ago • 2 comments

Spike

We need to agree upon which CSS styling pattern we want to use as there are numerous options

Patterns to consider

Styled components

Example libraries: Emotion, styled-jsx

Pros:

  • Makes components more self-contained Cons:
  • Code duplication

Utility classes

Example library: Tailwind

Pros:

  • Reusable css Cons:
  • Less straightforward,

Other

We might mix the two, use global stylesheets in addition.

Output

Styling pattern is chosen and documented in UI guidelines.

VakarisZ avatar Oct 17 '23 11:10 VakarisZ

sass + global styles + css modules + MUI

ordabach avatar Oct 17 '23 11:10 ordabach

related: https://github.com/guardicore/monkey/issues/1002

VakarisZ avatar Dec 14 '23 10:12 VakarisZ