2260 fix mypy issues
What does this PR do?
Fixes #2260.
Fixes a number of mypy issues.
PR Checklist
- [x] Have you added an explanation of what your changes do and why you'd like to include them?
- [ ] Is the TravisCI build passing?
- [ ] ~~Was the CHANGELOG.md updated to reflect the changes?~~
- [ ] ~~Was the documentation framework updated to reflect the changes?~~
- [ ] ~~Have you checked that you haven't introduced any duplicate code?~~
Testing Checklist
-
[ ] ~~Added relevant unit tests?~~
-
[ ] Have you successfully tested your changes locally? Elaborate:
Tested by running the unit tests
-
[x] If applicable, add screenshots or log transcripts of the feature working Prior to these changes:
Found 165 errors in 70 files (checked 586 source files)
After these changes:
Found 126 errors in 47 files (checked 586 source files)
Codecov Report
Base: 59.85% // Head: 60.23% // Increases project coverage by +0.37% :tada:
Coverage data is based on head (
4226d90) compared to base (dfa1709). Patch coverage: 77.61% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## develop #2330 +/- ##
===========================================
+ Coverage 59.85% 60.23% +0.37%
===========================================
Files 537 538 +1
Lines 13898 14011 +113
===========================================
+ Hits 8319 8439 +120
+ Misses 5579 5572 -7
| Impacted Files | Coverage Δ | |
|---|---|---|
| monkey/infection_monkey/monkey.py | 0.00% <ø> (ø) |
|
| monkey/monkey_island/cc/server_setup.py | 0.00% <0.00%> (ø) |
|
| ...rvices/telemetry/zero_trust_checks/segmentation.py | 55.31% <0.00%> (-1.21%) |
:arrow_down: |
| ...y/monkey_island/cc/setup/mongo/mongo_db_process.py | 35.13% <0.00%> (ø) |
|
| ...es/zero_trust/zero_trust_report/finding_service.py | 62.50% <20.00%> (-3.29%) |
:arrow_down: |
| ...land/cc/services/attack/technique_reports/T1065.py | 76.19% <50.00%> (+3.46%) |
:arrow_up: |
| monkey/infection_monkey/post_breach/pba.py | 56.09% <75.00%> (ø) |
|
| monkey/common/credentials/encoding.py | 100.00% <100.00%> (ø) |
|
| .../aggregating_propagation_credentials_repository.py | 95.91% <100.00%> (ø) |
|
| monkey/infection_monkey/exploit/HostExploiter.py | 79.71% <100.00%> (+0.29%) |
:arrow_up: |
| ... and 34 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.