dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Live Blog cards metadata colour -> neutral.100

Open bryophyta opened this issue 3 years ago • 4 comments

Live Blog cards The kicker and all metadata needs to change to neutral.100, other than Labs.

  • [x] DCR
  • [ ] Frontend

Part of an issue raised by @Bryony-Szekeres in https://github.com/guardian/dotcom-rendering/issues/4953#issuecomment-1139546312

bryophyta avatar Aug 04 '22 14:08 bryophyta

In our storybook we currently have stories for liveblogs on some palettes which don't have dark backgrounds, and also aren't Labs. e.g. LongRunningAltPalette: https://www.chromatic.com/component?appId=5dfcbf3012392c0020e7140b&csfId=layouts-palettes--long-running-alt-palette&buildNumber=14363&k=62eba7ec7afd5a3ca5789b26-1200-interactive-true&h=14&b=-2

Should we be converting the metadata colours for the dark palettes to neutral.100 (and leaving the light background ones as they are)? Or is it the case that some of these palettes will never actually have liveblogs associated with them?

(cc. @Bryony-Szekeres, @oliverlloyd, @HarryFischer)

image

bryophyta avatar Aug 04 '22 14:08 bryophyta

In our storybook we currently have stories for liveblogs on some palettes which don't have dark backgrounds, and also aren't Labs. e.g. LongRunningAltPalette: https://www.chromatic.com/component?appId=5dfcbf3012392c0020e7140b&csfId=layouts-palettes--long-running-alt-palette&buildNumber=14363&k=62eba7ec7afd5a3ca5789b26-1200-interactive-true&h=14&b=-2

Should we be converting the metadata colours for the dark palettes to neutral.100 (and leaving the light background ones as they are)? Or is it the case that some of these palettes will never actually have liveblogs associated with them?

(cc. @Bryony-Szekeres, @oliverlloyd, @HarryFischer)

image

When you put any card inside a container that has a 'Palette' (e.g.: containerPalette) applied to it, then that card has its normal colours overridden by the special palette, regardless of the type of card.

oliverlloyd avatar Aug 04 '22 14:08 oliverlloyd

Thanks! So for the palettes that do have dark backgrounds, presumably we do want to update the colour of the metadata to neutral.100? And I'll check this specific case of LongRunningAlt to see whether the current red styling has sufficient contrast or whether it should be changed to black, like for Labs.

bryophyta avatar Aug 04 '22 15:08 bryophyta

Having looked into the containerPalette overrides in a bit more detail, I think that a decision should probably be made on these separately, in consultation with design colleagues, because some of them differ quite a lot from other fronts cards.

bryophyta avatar Aug 08 '22 11:08 bryophyta