dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

"fixed/video" (`24`) container

Open bryophyta opened this issue 3 years ago • 1 comments

Part of https://github.com/guardian/dotcom-rendering/issues/4720

Please update FaciaPicker in Frontend once this container is supported by DCR

After proposing a basic solution (see this comment) it's now been agreed that this container should be fully migrated with the same features as Frontend (larger cards, play video in place, scoll when clicking offscreen cards).

This work may involve a refactor of Card and Carousel or it might make more sense to create new ones, maybe MediaCard and MediaCarousel?

bryophyta avatar Jun 07 '22 15:06 bryophyta

If we wanted a very quick win for the video container then one option is to repurpose the Carousel on a front

Image

With a little extra work, you can have a dark background

Image

oliverlloyd avatar Aug 30 '22 13:08 oliverlloyd

@rhiannareechaye @HarryFischer what do we think about this idea? Would save us a bunch of work ^^^ We can be flexible on actual colours here, but this layout already exists and it means not building yet another container type.

alinaboghiu avatar Jun 02 '23 10:06 alinaboghiu

@alinaboghiu Let me discuss with Alex and get back to you

HarryFischer avatar Jun 02 '23 10:06 HarryFischer

Hi @rhiannareechaye @alinaboghiu I have just come out of a long conversation around the vertical video text the EdEx team are doing. It reminded me of some key requirements for the video carousel on fronts...

  1. the video need to play from the front on both mobile and desktop, and not just link through to the article.
  2. they will need a play button, time stamp etc

Looking at the above this seems to be treating the videos like regular articles?

With the DCR version it feels we should take the opportunity to Build on the new design and experience that is being tested by the web ex team and not look to reduce functionality? Apologies if I have not understood how the above solution works.

ajbreuer avatar Jun 02 '23 15:06 ajbreuer

WIP here https://github.com/guardian/dotcom-rendering/pull/7227

DanielCliftonGuardian avatar Jun 05 '23 11:06 DanielCliftonGuardian

Reopening until https://github.com/guardian/dotcom-rendering/pull/8035 is done

alinaboghiu avatar Jun 25 '23 10:06 alinaboghiu