dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Format liveblock lastUpdated time

Open VDuczekW opened this issue 3 years ago • 1 comments

In https://github.com/guardian/dotcom-rendering/pull/3724 we make the apps-rendering liveblock show the correct format for the lastUpdated dateTime.

According to figma the format should be eg 11:56am 9 Jun 2021 [GMT]

While the apps-rendering codebase was updated with this correct date time, frontend has not been.

We believe the liveblock last updated dateTime is defined from here: https://github.com/guardian/frontend/blob/main/common/app/model/dotcomrendering/DotcomRenderingSupportTypes.scala#L84

We may need to create a new function in DatesAndTimes to capture the display requirements for liveblocks.

We may also want to consider migrating to java time (instead of joda time) for this use case (I believe this was something Pascal was working on, eg https://github.com/guardian/frontend/pull/24203)

When this ticket is done liveblocks rendered via dcr will display the last updated dateTime in the expected format, including an editionalised timezone.

VDuczekW avatar Mar 30 '22 14:03 VDuczekW

Adding to DCR for Apps so we can check timestamp alignment with apps before rolling out

alinaboghiu avatar Mar 07 '24 18:03 alinaboghiu