`DCRArticle` Uses `ArticleFormat`

[JamieB-gu]

Part of a series of changes to get DCR using ArticleFormat exclusively, rather than a mix of that and FEFormat. This changes the format field in DCRArticle to be of type ArticleFormat instead of FEFormat.

This is in draft for now because it depends on changes in #10798, #10799 and #10800.

[github-actions[bot]]

Deploy build 32492 of Mobile::mobile-apps-rendering to CODE

All deployment options

• Deploy build 32492 of Mobile::mobile-apps-rendering to CODE
• Deploy parts of build 32492 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[github-actions[bot]]

Size Change: 0 B

Total Size: 760 kB

ℹ️ View Unchanged

Filename	Size
dotcom-rendering/dist/1011.client.web.********************.js	3.14 kB
dotcom-rendering/dist/112.client.web.********************.js	822 B
dotcom-rendering/dist/1191.client.web.********************.js	680 B
dotcom-rendering/dist/1192.client.web.********************.js	3.69 kB
dotcom-rendering/dist/1407.client.web.********************.js	640 B
dotcom-rendering/dist/1429.client.web.********************.js	17.9 kB
dotcom-rendering/dist/1459.client.web.********************.js	876 B
dotcom-rendering/dist/1519.client.web.********************.js	6.12 kB
dotcom-rendering/dist/1530.client.web.********************.js	8.59 kB
dotcom-rendering/dist/1541.client.web.********************.js	2.89 kB
dotcom-rendering/dist/1549.client.web.********************.js	4.81 kB
dotcom-rendering/dist/17.client.web.********************.js	1.85 kB
dotcom-rendering/dist/1749.client.web.********************.js	920 B
dotcom-rendering/dist/1827.client.web.********************.js	2.65 kB
dotcom-rendering/dist/1937.client.web.********************.js	2.43 kB
dotcom-rendering/dist/2293.client.web.********************.js	582 B
dotcom-rendering/dist/2337.client.web.********************.js	23.1 kB
dotcom-rendering/dist/2363.client.web.********************.js	5.87 kB
dotcom-rendering/dist/2364.client.web.********************.js	3.79 kB
dotcom-rendering/dist/2412.client.web.********************.js	3.67 kB
dotcom-rendering/dist/2443.client.web.********************.js	3 kB
dotcom-rendering/dist/2572.client.web.********************.js	3.47 kB
dotcom-rendering/dist/3170.client.web.********************.js	527 B
dotcom-rendering/dist/3235.client.web.********************.js	529 B
dotcom-rendering/dist/3375.client.web.********************.js	2.7 kB
dotcom-rendering/dist/3396.client.web.********************.js	5.75 kB
dotcom-rendering/dist/351.client.web.********************.js	618 B
dotcom-rendering/dist/3671.client.web.********************.js	435 B
dotcom-rendering/dist/3737.client.web.********************.js	2.94 kB
dotcom-rendering/dist/393.client.web.********************.js	920 B
dotcom-rendering/dist/3936.client.web.********************.js	2.81 kB
dotcom-rendering/dist/3986.client.web.********************.js	495 B
dotcom-rendering/dist/4040.client.web.********************.js	650 B
dotcom-rendering/dist/4045.client.web.********************.js	643 B
dotcom-rendering/dist/405.client.web.********************.js	914 B
dotcom-rendering/dist/4055.client.web.********************.js	3.2 kB
dotcom-rendering/dist/4269.client.web.********************.js	668 B
dotcom-rendering/dist/4390.client.web.********************.js	508 B
dotcom-rendering/dist/4434.client.web.********************.js	3.68 kB
dotcom-rendering/dist/4438.client.web.********************.js	801 B
dotcom-rendering/dist/4442.client.web.********************.js	714 B
dotcom-rendering/dist/478.client.web.********************.js	595 B
dotcom-rendering/dist/4870.client.web.********************.js	748 B
dotcom-rendering/dist/4911.client.web.********************.js	780 B
dotcom-rendering/dist/5020.client.web.********************.js	994 B
dotcom-rendering/dist/5047.client.web.********************.js	779 B
dotcom-rendering/dist/5055.client.web.********************.js	4.6 kB
dotcom-rendering/dist/5196.client.web.********************.js	13.2 kB
dotcom-rendering/dist/5569.client.web.********************.js	3.56 kB
dotcom-rendering/dist/5619.client.web.********************.js	926 B
dotcom-rendering/dist/5730.client.web.********************.js	954 B
dotcom-rendering/dist/5985.client.web.********************.js	750 B
dotcom-rendering/dist/6043.client.web.********************.js	852 B
dotcom-rendering/dist/6140.client.web.********************.js	853 B
dotcom-rendering/dist/6302.client.web.********************.js	2.68 kB
dotcom-rendering/dist/6351.client.web.********************.js	3.42 kB
dotcom-rendering/dist/6651.client.web.********************.js	904 B
dotcom-rendering/dist/6693.client.web.********************.js	822 B
dotcom-rendering/dist/6697.client.web.********************.js	3.37 kB
dotcom-rendering/dist/6847.client.web.********************.js	4.85 kB
dotcom-rendering/dist/6853.client.web.********************.js	1 kB
dotcom-rendering/dist/6981.client.web.********************.js	3.87 kB
dotcom-rendering/dist/7018.client.web.********************.js	787 B
dotcom-rendering/dist/7024.client.web.********************.js	3.6 kB
dotcom-rendering/dist/7324.client.web.********************.js	3.49 kB
dotcom-rendering/dist/7356.client.web.********************.js	1 kB
dotcom-rendering/dist/764.client.web.********************.js	6.02 kB
dotcom-rendering/dist/7673.client.web.********************.js	2.95 kB
dotcom-rendering/dist/7855.client.web.********************.js	788 B
dotcom-rendering/dist/8002.client.web.********************.js	801 B
dotcom-rendering/dist/8030.client.web.********************.js	3.77 kB
dotcom-rendering/dist/8166.client.web.********************.js	1.56 kB
dotcom-rendering/dist/8288.client.web.********************.js	23 kB
dotcom-rendering/dist/841.client.web.********************.js	789 B
dotcom-rendering/dist/8430.client.web.********************.js	2.54 kB
dotcom-rendering/dist/8587.client.web.********************.js	41.7 kB
dotcom-rendering/dist/8695.client.web.********************.js	8.67 kB
dotcom-rendering/dist/8749.client.web.********************.js	3.27 kB
dotcom-rendering/dist/8818.client.web.********************.js	748 B
dotcom-rendering/dist/8937.client.web.********************.js	888 B
dotcom-rendering/dist/898.client.web.********************.js	3.74 kB
dotcom-rendering/dist/9140.client.web.********************.js	8.28 kB
dotcom-rendering/dist/9173.client.web.********************.js	723 B
dotcom-rendering/dist/9314.client.web.********************.js	822 B
dotcom-rendering/dist/9605.client.web.********************.js	4.79 kB
dotcom-rendering/dist/9621.client.web.********************.js	723 B
dotcom-rendering/dist/9676.client.web.********************.js	889 B
dotcom-rendering/dist/9727.client.web.********************.js	5.89 kB
dotcom-rendering/dist/9886.client.web.********************.js	9.99 kB
dotcom-rendering/dist/9978.client.web.********************.js	960 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js	3.75 kB
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js	424 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js	4.15 kB
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js	3.65 kB
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js	3.02 kB
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js	2.45 kB
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js	3.63 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js	2.03 kB
dotcom-rendering/dist/Branding-importable.client.web.********************.js	2.65 kB
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js	36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js	1.91 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js	6.78 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js	5.78 kB
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js	4.84 kB
dotcom-rendering/dist/Carousel-importable.client.web.********************.js	5.56 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js	5.66 kB
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js	538 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js	3.29 kB
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js	2.46 kB
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js	4.06 kB
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js	1.67 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js	3.61 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js	4.16 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js	2.01 kB
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js	2.43 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js	3.35 kB
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js	611 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js	841 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js	342 B
dotcom-rendering/dist/frameworks.client.web.********************.js	20.7 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js	3.82 kB
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js	10.8 kB
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js	1.68 kB
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js	2.67 kB
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js	15 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js	9.45 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js	780 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js	12.3 kB
dotcom-rendering/dist/index.client.web.********************.js	47.6 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js	3.7 kB
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js	850 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js	6.09 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js	4.72 kB
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js	3.49 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js	4.59 kB
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js	3.54 kB
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js	2.22 kB
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js	434 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js	6.46 kB
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js	3.6 kB
dotcom-rendering/dist/Liveness-importable.client.web.********************.js	4.95 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js	6.63 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js	5.69 kB
dotcom-rendering/dist/Metrics-importable.client.web.********************.js	2.29 kB
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js	4.04 kB
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js	6.73 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js	4.44 kB
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js	4.05 kB
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js	3.66 kB
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js	542 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js	800 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js	749 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js	537 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js	469 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js	1.89 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js	3.65 kB
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js	1.99 kB
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js	6.25 kB
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js	3.63 kB
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js	4.43 kB
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js	2.13 kB
dotcom-rendering/dist/sentry.client.web.********************.js	786 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js	3.42 kB
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js	485 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js	1.52 kB
dotcom-rendering/dist/shimport.client.web.********************.js	2.79 kB
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js	647 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js	5.71 kB
dotcom-rendering/dist/SignInGateMain.client.web.********************.js	3.93 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js	5.04 kB
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js	5.64 kB
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js	4.16 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js	5.53 kB
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js	5.65 kB
dotcom-rendering/dist/SubNav-importable.client.web.********************.js	2.25 kB
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js	3.77 kB
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js	3.17 kB
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js	1.24 kB
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js	1.02 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js	3.71 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js	5.7 kB
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js	3.54 kB
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js	5.47 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js	3.97 kB

_{compressed-size-action}

[github-actions[bot]]

Hello :wave:! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

Click here to see the Chromatic project.

[JamieB-gu]

Playwright is failing because our fixtures are overloaded. They're of type DCRArticle, but they're being used in places where FEArticleType is expected. This hasn't caused problems so far because of structural typing, but the two types have diverged enough in this change to cause a problem.

In summary, the Playwright test tries to post one of our fixtures to the DCR server, where JSON of a structure that matches FEArticleType is expected. However, the fixture is of type DCRArticle and this now means a divergence in the format field, which causes the schema validation to fail.

A couple of possible solutions to this problem:

1. Create parallel sets of fixtures: one set of type FEArticleType and one set of type DCRArticle.
2. Make all fixtures of type FEArticleType, and parse/enhance these to DCRArticle whenever needed.

[arelra]

Playwright is failing because our fixtures are overloaded. They're of type DCRArticle, but they're being used in places where FEArticleType is expected. This hasn't caused problems so far because of structural typing, but the two types have diverged enough in this change to cause a problem.

In summary, the Playwright test tries to post one of our fixtures to the DCR server, where JSON of a structure that matches FEArticleType is expected. However, the fixture is of type DCRArticle and this now means a divergence in the format field, which causes the schema validation to fail.

A couple of possible solutions to this problem:

1. Create parallel sets of fixtures: one set of type FEArticleType and one set of type DCRArticle.
2. Make all fixtures of type FEArticleType, and parse/enhance these to DCRArticle whenever needed.

Thanks for explaining this! Just recording what we discussed - my vote is option 1 as it seems like the most pragmatic path for now.

[github-actions[bot]]

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

[github-actions[bot]]

This PR was closed because it has been stalled for 3 days with no activity.