cloud-nuke icon indicating copy to clipboard operation
cloud-nuke copied to clipboard

migrate: aws v2 - vpc lattice

Open james00012 opened this issue 1 year ago • 1 comments

Description

Partially fixing https://github.com/gruntwork-io/cloud-nuke/issues/770

TODOs

Read the Gruntwork contribution guidelines.

  • [ ] Update the docs.
  • [ ] Run the relevant tests successfully, including pre-commit checks.
  • [ ] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • [ ] Include release notes. If this PR is backward incompatible, include a migration guide.
  • [ ] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

james00012 avatar Oct 19 '24 00:10 james00012

hey @james03160927

can you run

 go generate ./...

this should update the the v2_migration_report/output.md file.

wakeful avatar Oct 20 '24 11:10 wakeful

Hi @denis256, addressed your comments. PTAL.

james00012 avatar Oct 24 '24 21:10 james00012