grpc
A76: Improvements to the Ring Hash LB Policy
@markdroth just checking in on this, I've made the updates regarding handling the empty header. I'll start testing an implementation for this internally, but in the meantime would appreciate another review. Thanks!
@atollena, can you address the few remaining open comments? It would be good to get this merged. Thanks!
@atollena, can you address the few remaining open comments? It would be good to get this merged. Thanks!
Hey Mark, sorry for the delay on this, this time it was me being swamped by other things. I'll get to it in the next few days.
No worries, thank you!
FYI, I've thrown together an implementation of this in C-core in https://github.com/grpc/grpc/pull/38312.
FYI, I've thrown together an implementation of this in C-core in grpc/grpc#38312.
I have changed the pseudo-code to match the code in c-core, it maps very nicely.
@atollena, do you plan to revive and complete grpc/grpc-go#7170, and if so have the timeline? I'm waiting for this to be implemented in Go and found your old PR.
@atollena, do you plan to revive and complete grpc/grpc-go#7170, and if so have the timeline? I'm waiting for this to be implemented in Go and found your old PR.
I don't have a timeline, but the work involves converting the ring hash balancer to use pick first as leaf, first, and that wasn't ready until recently (https://github.com/grpc/proposal/blob/master/A61-IPv4-IPv6-dualstack-backends.md#ring-hash). I'll check with the go team to see whether we're ready to start that work.