grpc icon indicating copy to clipboard operation
grpc copied to clipboard

[examples/systemd activation] multiple fixtures for testing different unix enpoints

Open nipil opened this issue 1 year ago • 1 comments

The test script only handled one socket type/name at a time. Rewrite the script to handle multiple test fixtures, and add tests easily.

To keep existing behaviour, returns the number of FAILED test as exit value : so when all tests pass, exits with 0, and if any test fails, exit with non-zero.

The tests provided in this PR all pass, when the following PR regarding systemd socket activation fixes are active :

  • #36034 (included)
  • #36035 (included)
  • #36036
  • #36039
  • #36041

Tested with :

  • systemd 247 on debian 11
  • iomgr (experiments event_engine_listener posix=false)

nipil avatar Mar 03 '24 10:03 nipil

This appears to depend on https://github.com/grpc/grpc/pull/36035. I'll review it afterwards. In the meantime, please test with the event_engine_listener experiment as well, iomgr is being deprecated.

drfloob avatar Mar 08 '24 18:03 drfloob

More than 30 days have passed since label "disposition/requires reporter action" was added. Closing this issue. Please feel free to re-open/create a new issue if this is still relevant.

grpc-bot avatar Jul 15 '24 00:07 grpc-bot