grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

NettyFlowControlTest is flaky

Open lukaszx0 opened this issue 9 years ago • 124 comments

Happened few times for me, in CI as well as locally:

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:171)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:141)

lukaszx0 avatar Sep 23 '16 13:09 lukaszx0

How often is this happening? I assume you've just been noticing it on your hardware?

ejona86 avatar Oct 20 '16 20:10 ejona86

Nope, it happened in CI too (sorry, don't have link handy). Can't tell how often, but last time I was contributing something, I got beaten by it 3-4 times during development (so both local and remote CI)

lukaszx0 avatar Oct 20 '16 20:10 lukaszx0

What I tend to encourage is that each time you see it, put a comment here (with a link if you have one). That way we can see how much pain it is causing, or whether it just happened once to one person.

ejona86 avatar Oct 20 '16 21:10 ejona86

Yeah, my bad. Sorry, will do!

On Thu, Oct 20, 2016 at 2:52 PM, Eric Anderson [email protected] wrote:

What I tend to encourage is that each time you see it, put a comment here (with a link if you have one). That way we can see how much pain it is causing, or whether it just happened once to one person.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/grpc/grpc-java/issues/2297#issuecomment-255238735, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAtKqe0zzES0ADnOaY_nnZK8M7v8VWBks5q1-KagaJpZM4KE_1h .

Łukasz

lukaszx0 avatar Oct 25 '16 18:10 lukaszx0

Just happened to me locally:

objc[44415]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
[jetty-alpn-agent] Using: alpn-boot-8.1.8.v20160420.jar

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)

242 tests completed, 1 failed
:grpc-interop-testing:test FAILED

FAILURE: Build failed with an exception.

lukaszx0 avatar Nov 03 '16 16:11 lukaszx0

Failed with https://travis-ci.org/grpc/grpc-java/jobs/176197614 (since rebuilt)

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 688278 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)

ejona86 avatar Nov 24 '16 00:11 ejona86

Failed locally:

:grpc-interop-testing:test
objc[83215]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/bin/java (0x10dad54c0) and /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/lib/libinstrument.dylib (0x10db9d4e0). One of the two will be used. Which one is undefined.
[jetty-alpn-agent] Using: alpn-boot-8.1.8.v20160420.jar

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)

246 tests completed, 1 failed

lukaszx0 avatar Dec 03 '16 23:12 lukaszx0

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2740/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655360 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)

ejona86 avatar Jan 09 '17 17:01 ejona86

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2859/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 816980 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)

ejona86 avatar Jan 27 '17 17:01 ejona86

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2909/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)

ejona86 avatar Feb 07 '17 16:02 ejona86

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2968/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)

ejona86 avatar Feb 27 '17 17:02 ejona86

Nowadays, I'm hitting it pretty much every time I'm working on PR. Is is still worth posting failed builds here?

lukaszx0 avatar Mar 01 '17 18:03 lukaszx0

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/3316/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 687918 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)

ericgribkoff avatar May 01 '17 21:05 ericgribkoff

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/46/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Jul 25 '17 18:07 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/50/

java.lang.AssertionError: Window was 655360 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Jul 25 '17 23:07 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/54/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Jul 31 '17 20:07 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/157/

java.lang.AssertionError: Window was 720686 expecting 314570
 	at org.junit.Assert.fail(Assert.java:88) 	
        at org.junit.Assert.assertTrue(Assert.java:41) 	
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154) 
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ericgribkoff avatar Aug 08 '17 00:08 ericgribkoff

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/63/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124

ejona86 avatar Aug 09 '17 17:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/204/

java.lang.AssertionError: Window was 655360 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ericgribkoff avatar Aug 11 '17 18:08 ericgribkoff

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/78/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Aug 12 '17 00:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/104/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Aug 25 '17 16:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/105/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Aug 25 '17 18:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/307/

java.lang.AssertionError: Window was 687918 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Aug 28 '17 16:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/310/

java.lang.AssertionError: Window was 753454 expecting 314570
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
	at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)

ejona86 avatar Aug 28 '17 17:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/111/

ejona86 avatar Aug 28 '17 21:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/112/

ejona86 avatar Aug 29 '17 16:08 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/115/ (from Aug 31)

ejona86 avatar Sep 14 '17 22:09 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/132/

ejona86 avatar Sep 15 '17 15:09 ejona86

https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/4246/console

ejona86 avatar Sep 15 '17 16:09 ejona86

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/134/

ejona86 avatar Sep 18 '17 16:09 ejona86