tweaks icon indicating copy to clipboard operation
tweaks copied to clipboard

returning nil is destructive and breaks stuff

Open orikad opened this issue 13 years ago • 3 comments

so just use the hidden property instead?

orikad avatar May 10 '12 04:05 orikad

What's destructive about it? What does it break?

I would note that setting it hidden will, in fact, not work as currently implemented. SBIconController manages its own visible state for the page control (toggled in places such as the app switcher and folders) and so this will only work temporarily.

grp avatar May 10 '12 04:05 grp

While it may be argued that using SBIconController for those uses is better, SBIconListPageControl may be used for querying how many home screen pages are available or what is the current page. Just returning nil breaks those sort of uses of SBIconListPageControl.

orikad avatar May 10 '12 04:05 orikad

My response: don't use it for that, then. :)

grp avatar May 12 '12 08:05 grp