PullToRefreshView icon indicating copy to clipboard operation
PullToRefreshView copied to clipboard

Enable compiling with ARC and non-ARC

Open zman0900 opened this issue 13 years ago • 3 comments

Using the method described at http://mobile.dzone.com/articles/arc-support-without-branching I modified the code so it will compile for ARC projects while still being compatible with non-ARC projects.

zman0900 avatar May 04 '12 11:05 zman0900

Looks good; nice recognition of the... "unique" memory management used in here.

Only question is if ARCMacros.h is necessary. Maybe it'd be better to move those (and possibly rename them with a PtR related prefix) into the main header, to be sure it doesn't conflict?

grp avatar May 05 '12 01:05 grp

The contents of that file were taken unmodified from another site, so that's why I left them in their own file. The file could just be prefixed with PullToRefresh to avoid having to move its contents...

Edit: I made the changed and committed to the same topic branch, but it is not showing up here.

zman0900 avatar Jun 15 '12 13:06 zman0900

I would prefer they weren't here at all — I think they're reasonably unnecessary for a tiny project this size. Honestly, I'm not 100% sure why this is needed at all: with a few changes to the header, PullToRefreshView should be fine in both ARC and non-ARC projects, since you can have both types of code in one project.

grp avatar Jul 09 '12 04:07 grp