PullToRefreshView icon indicating copy to clipboard operation
PullToRefreshView copied to clipboard

Issue with tableview

Open Bensge opened this issue 14 years ago • 4 comments

I tried to add this to my tableview. I can see the arrow on top of the tableview, but the arrow isn't rotating or anything. I think it isn't recognizing my tableview as a scrollview. How can i fix that?

Bensge avatar Jan 14 '12 12:01 Bensge

Same issue here. Not that it should matter, but I'm in a storyboard-based project. I'm going to try and debug what is going on.

gmckenzi avatar Jan 14 '12 14:01 gmckenzi

Problem is that commit a45158 accidentally dropped this line from near the end of initWithScrollView:

    [self setState:kPullToRefreshViewStateNormal];

See my modified PullToRefreshView.m in this gist here:

https://gist.github.com/1611706

gmckenzi avatar Jan 14 '12 14:01 gmckenzi

Another issue...the statusLabel doesn't appear anymore as the statusLabel initializer was changed in commit 3238b01cfd. Prior to that commit the statusLabel initializer was:

statusLabel = [[UILabel alloc] initWithFrame:CGRectMake(0.0f, frame.size.height - 48.0f, self.frame.size.width, 20.0f)];

I've updated the gist ( https://gist.github.com/1611706 )

gmckenzi avatar Jan 14 '12 15:01 gmckenzi

@gmckenzi Since you actually found the issues, are you interested in doing a fork and pull request to get this project updated? I have added the changes you mentioned to my own fork, but I want credit to go to you since you did the actual hard work. If you just want me to issue the pull request, I can.

Or I guess hopefully chpwn can get it updated as well based off your gist.

ryanwersal avatar Jan 17 '12 14:01 ryanwersal