Tutorials icon indicating copy to clipboard operation
Tutorials copied to clipboard
verified publisher icon gridap

Fixed typos in Poisson Transient driver

Open ericneiva opened this issue 3 years ago • 2 comments

Hi, @fverdugo,

I found a couple of obvious typos in the Poisson transient driver.

Could you please review and merge whenever you have some time?

Thank you!

ericneiva avatar Jun 16 '22 08:06 ericneiva

Hi @ericneiva ! Thanks for the PR! Do you know why it did run successfully?

amartinhuertas avatar Jun 16 '22 09:06 amartinhuertas

Hi, @amartinhuertas, good question! I didn't look into that. I barely have experience with the transient machinery and I would need some time to figure out why the tests were passing before.

ericneiva avatar Jun 16 '22 10:06 ericneiva

Hi @amartinhuertas @ericneiva . Thanks for spotting and fixing these typos. The definition of ConstantMatrix and Constant operators are there just to show how would it work for the respective cases. These operators are not used to get the solution and, thus, the test doesn't fail. If they would have been used, they would have failed.

oriolcg avatar Jan 23 '23 16:01 oriolcg

Yes, exactly, @oriolcg. Thanks for clarifying this.

ericneiva avatar Jan 23 '23 16:01 ericneiva