react-firestore icon indicating copy to clipboard operation
react-firestore copied to clipboard

Typescript support

Open alexstrat opened this issue 7 years ago • 1 comments

If someone (me or anyone else) would like to add Typescript support to react-firestore, would you prefer:

  1. the whole project to be migrated to Typescript, or
  2. an independent type definition to be maintained via DefinitelyTyped.

From a TS user perspective the solution 1/ is preferable since it prevents type definition to drift appart from actual library but it requires that the library is maintained in TS (which has numerous benefits :))

👋

alexstrat avatar Mar 28 '18 10:03 alexstrat

@alexstrat - Although it would be preferable to use typescript in the project for typescript consumers, I believe it would require pretty significant effort to the build system. Currently we use kcd-scripts to build the project, and moving to typescript would mean we could no longer use that and would have to create a custom build. For that reason I'd prefer an independent type definition. We could also add types for flow as well.

Thanks for bringing this up!

green-arrow avatar Mar 29 '18 13:03 green-arrow