core icon indicating copy to clipboard operation
core copied to clipboard

Typo in settings.c

Open andrewmarles opened this issue 1 year ago • 1 comments

I think that on lines 2010 and lines 2023 that the bang should not be prefixed on the call to spindle_get_caps: https://github.com/grblHAL/core/blob/9a060d7ea0f01cab7444fee447741b010cb4cb3a/settings.c#L2010 https://github.com/grblHAL/core/blob/9a060d7ea0f01cab7444fee447741b010cb4cb3a/settings.c#L2023

I think they should be

available = hal.signals_cap.safety_door_ajar && spindle_get_count() && spindle_get_caps(true).at_speed;

Otherwise the spindles with speed feedback all return false on this check.

andrewmarles avatar Jun 21 '24 22:06 andrewmarles

This gets complicated when more than one spindle (not counting spindles that are not spinning) is configured and not all are at speed capable since the value is used as the timeout for at speed capable spindles. I guess a new setting for the timeout is required.

terjeio avatar Jun 22 '24 04:06 terjeio

No longer relevant due to recent settings changes. Closed.

terjeio avatar Feb 17 '25 21:02 terjeio