graspologic icon indicating copy to clipboard operation
graspologic copied to clipboard

Added density test and group connection test to inference module

Open jwellan1 opened this issue 3 years ago • 1 comments

  • [X] Does this PR have a descriptive title that could go in our release notes?
  • [X] Does this PR add any new dependencies?
  • [X] Does this PR modify any existing APIs?
    • [X] Is the change to the API backwards compatible?
  • [ ] Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Reference Issues/PRs

Continuation of PR #981 (now using a new branch because prior branch was compromised)

What does this implement/fix? Briefly explain your changes.

This PR adds the density test and group connection test to the inference module, enabling statistical comparison of two networks under either the Erdos-Renyi model (density test) or the Stochastic Block Model (group connection test).

Any other comments?

jwellan1 avatar Sep 19 '22 19:09 jwellan1

Review TODOs (for me)

  • [x] review docstrings
  • [x] fix typing issue
  • [ ] review tests
  • [ ] review notebooks
  • [ ] benchmark against old code and simulations

bdpedigo avatar Oct 14 '22 17:10 bdpedigo